-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Excited State Final Cleanup #2569
Conversation
db4ffa5
to
7813b5d
Compare
Still in the draft stage, but next round of edits is in. I need to give the tests another pass to make sure we have proper coverage. The other major issue is the docs. I'll need to update the section describing excite state psivars, but @loriab, how do you feel about grouping psivars together? See discussion here. |
I'd still strongly favor something like the below. It lets the variables (n,m,h,i) be defined in the definition, and new methods can join existing psivar entries. Also just less visual clutter when all but the methods line up. What do you think?
|
I wish there was a way to cut down the repetition in variable description, but from the user standpoint, that probably is the way to go... I'll get docs up and un-draft this (hopefully tonight) and save test pass for tomorrow. |
In another project, I have the glossary-like doc generated by python to cut down on that. Perhaps someday ... |
Docs took way longer than expected, but that part is done. Now to give tests a sweep. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
congratulations and thanks on wrangling a rather mind-numbing PR. I know you have another pass planned, so here's some first-look comments.
.. psivar:: ADC ROOT 0 (h) -> ROOT m (i) OSCILLATOR STRENGTH (VEL) | ||
TD-fctl ROOT 0 (h) -> ROOT m (i) OSCILLATOR STRENGTH (VEL) | ||
|
||
The velocity-gauge oscillator strength of the transition from root *n* to root *m*, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
definition mentions n but variables fixed at n=0. generalize variables?
|
||
.. psivar:: ADC ROOT 0 -> ROOT m ROTATORY STRENGTH (VEL) | ||
CCname ROOT n -> ROOT m ROTATORY STRENGTH (VEL) | ||
TD-fctl ROOT 0 -> ROOT m ROTATORY STRENGTH (VEL) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing def
|
||
Redundant quadrupole array [e a0^2] for the requested coupled cluster level of theory and root *n*, and the transition is of irrep *h*, (*n* starts at 0), (3,3). | ||
|
||
.. psivar:: CCname ROOT m -> ROOT n EINSTEIN A (LEN) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are these m -> n
for a reason (instead of n -> m
as above)? if anything, spectroscopic notation is to <- from
, but I think we're steady on from -> to
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excited state QCVars much improved compared to the start of this saga. And I think the (IN h)
is a nice clear marker of the intra-irrep numbering scheme.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for doing this! LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Description
This will eventually conclude the standardizing of excited state variable names across all of Psi and the docs.
Right now, this just standardizes TD-DFT psivars for final comments. This is a short-and-sweet spec of the new standard that I'm putting up for comments. (Largely from @loriab)
Todos
Checklist
Status