potential_ moved to subclasses. #2889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonathonMisiewicz
force-pushed
the
2885_move_potential
branch
from
3163adf
to
d6081f8
Compare
loriab
approved these changes
Feb 25, 2023
JonathonMisiewicz
force-pushed
the
2885_move_potential
branch
from
d6081f8
to
8616d2e
Compare
JonathonMisiewicz
force-pushed
the
2885_move_potential
branch
from
8616d2e
to
623d8b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
potential_of SCF subclasses has been moved.Dev notes & details
std::shared_ptr<VBase> potential_to having a methodget_potential()that returns astd::shared_ptr<VBase>. After Triplet TDDFT #2885, the subclasses may need to access subclass-specific methods.Checklist
Status