-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable dd-solvated TDSCF #2967
Enable dd-solvated TDSCF #2967
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat! Glad the cpscf
interface seems to work with more and more models 😄
I don't really see if the CI failures are related to my changes. @loriab Any ideas? |
The problems are unrelated to this PR. Rebase and push, and the problems will be fixed. (Psi's "grab the latest pydantic" will use an updated pydantic, which won't raise the error.) I'll review this PR later today, since I know the TDSCF code the best, nowadays. |
can only be used for energy calculations with SCF | ||
wavefunctions. All ERI algorithms (``PK``, ``OUT_OF_CORE``, ``DIRECT``, ``DF``, | ||
``CD``) are supported. | ||
.. note:: At present PCM can only be used for energy calculations with SCF |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.. note:: At present PCM can only be used for energy calculations with SCF | |
.. note:: At present, PCM can only be used for energy calculations with SCF |
The Win failures are the pydantic 1.10.7 + typing extensions 4.6 we were seeing yesterday. It should have cleared up, some I'm retriggering one to check. |
Thanks @JonathonMisiewicz and @loriab ! |
Description
Extends DDX interface to support SCF response and TDSCF.
Checklist
Status