Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to pass get variable in url #70

Open
ronluna opened this issue Feb 17, 2024 · 7 comments
Open

Unable to pass get variable in url #70

ronluna opened this issue Feb 17, 2024 · 7 comments
Assignees

Comments

@ronluna
Copy link

ronluna commented Feb 17, 2024

Seems like entering player's mac address and or forcing a theme color in the url is getting completely ignored and simply load the initial page and not the player or theme specified in the url. any ideas ?

https://ha_server:8123/hassio/ingress/gs57c884_lms/?player=3c:d4:3c:ee:ea:5c&theme=dark

This works fine when not using ingress as:

http://ha_server:9000/?player=3c:d4:3c:ee:ea:5c&theme=dark

any ideas?

@ronluna ronluna changed the title Unable to pass get veriable in url Unable to pass get variable in url Feb 17, 2024
@pssc
Copy link
Owner

pssc commented Mar 1, 2024

@ronluna its in the query string? I don't touch that. Its not something I have tired but I only support the default and material themes through ingress each theme requires custom rewrite rules for the ingress interface, which I have supplied at need to be turned on in the addon config for a specific theme.

@ronluna
Copy link
Author

ronluna commented Mar 5, 2024

It's for both. default and material theme. I only use those two... it simply allows to force the material's theme and also forces the specified player when the mac address is in the url string. This come very handy when wanting to interact directly with a specific player once the HA user is at a specific area/room. Would be great to get it this working with ingress.

you can see the list of different querystrings supported by the material theme here:

https://github.com/CDrummond/lms-material/wiki/13-URL-query-parameters

@pssc
Copy link
Owner

pssc commented Mar 6, 2024

As said ingress needs different rules for different themes, there is no facility to change this on the fly per client through ingress.

@pssc
Copy link
Owner

pssc commented Mar 8, 2024

@ronluna the penny dropped on what your trying to do when debugging another issue in the material skin, your using the theme selection in the material skin?

@pssc pssc self-assigned this Mar 8, 2024
pssc pushed a commit that referenced this issue Mar 8, 2024
@ronluna
Copy link
Author

ronluna commented Mar 9, 2024

Not quite sure if I get the question above. theme selection as if the "Material" Skin was chose under the interface tab in LMS settings and I'm the ?theme=(light|dark) querystring as an argument ? If that's what the question meant.. then yes!

@pssc
Copy link
Owner

pssc commented May 24, 2024

In theory this should now work, there is nothing I can see now preventing it

@pssc
Copy link
Owner

pssc commented May 30, 2024

After some testing this still doesn't work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants