fix a problem where backslashes break rsync on Windows

pstadler · Nov 11, 2014 · 97bff09 · 97bff09
1 parent 3269198
commit 97bff09
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/lib/transport/shell.js b/lib/transport/shell.js
@@ -80,6 +80,8 @@ ShellTransport.prototype.__transfer = function(files, remoteDir, options) {
   }
 
   var tmpTransferListFile = tempWrite.sync(files);
+  // escape backslashes (Windows)
+  var escapedTmpTransferListFile = tmpTransferListFile.replace(/\\/g, '\\\\');
 
   var rsyncFlags = '-az' + (this.logger.debugEnabled() ? 'vv': '');
   var _results = [];
@@ -93,8 +95,8 @@ ShellTransport.prototype.__transfer = function(files, remoteDir, options) {
                                 , config.host, remoteDir);
 
       var cmd = util.format('rsync --files-from %s %s --rsh="ssh -p%s%s" ./ %s'
-                                , tmpTransferListFile, rsyncFlags, config.port || 22
-                                , sshFlags, remoteUrl);
+                                , escapedTmpTransferListFile, rsyncFlags
+                                , config.port || 22, sshFlags, remoteUrl);
 
       _results.push(this.exec(cmd, options));
       return future.return();

diff --git a/package.json b/package.json
@@ -1,7 +1,7 @@
 {
   "name": "flightplan",
   "description": "Library for streamlining application deployment or systems administration tasks",
-  "version": "0.4.3",
+  "version": "0.4.4",
   "author": "Patrick Stadler <patrick.stadler@gmail.com>",
   "keywords": [
     "deploy",