Changed ssh stream to listen for 'end' event rather than 'close' #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this pull request 🍻 |
pstadler
added a commit
that referenced
this pull request
Jan 5, 2016
Changed ssh stream to listen for 'end' event rather than 'close'
|
0.6.9 has been released: https://github.com/pstadler/flightplan/releases/tag/0.6.9 |
|
Glad to help, flightplan is a really useful tool 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using end instead of close appears to resolve issues I was having where intermittently the ssh command was completing but nothing was put in the stdout. The end event "will not fire unless the data is completely consumed" (https://nodejs.org/api/stream.html#stream_event_end) so this seems to be want we want. Tested on node v5.3.0.