Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what's done:
util.inherits
withclass
for the transports(removed some related tests)unable to load module
error handler frombin.js
, it is no longer thrown when requiring ats
filenyc
instead ofistanbul
what's not done:
class
inerrors.js
andtransport/index.js
after this change, the old API will not work, we need to add
await
before everyexec
related function when defining the tasks, but this makes theflightplan.js
file more like a normal js file, users can use async/await in the task defines which they can not do in the fibers version.I'm not sure if this is good for everyone, but I'll submit this first and see what will come up.