Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't do local-only snapshots if dataset is received #150

Closed
digitalsignalperson opened this issue Jun 21, 2022 · 5 comments
Closed

Can't do local-only snapshots if dataset is received #150

digitalsignalperson opened this issue Jun 21, 2022 · 5 comments

Comments

@digitalsignalperson
Copy link
Contributor

If I just want to snapshot and thin locally, e.g.

zfs-autobackup -v --keep-source 5,1min5min testdata

I'm running into

  #### Selecting
  NOTE: Source and target are on the same host, excluding received datasets from selection.
  [Source] fpool/testdata: Excluded (dataset already received)
! No source filesystems selected, please do a 'zfs set autobackup:testdata=true' on the source datasets you want to select.

when I have previously received the dataset

NAME                                                  PROPERTY             VALUE                SOURCE
fpool/testdata                                        autobackup:testdata  true                 received

But I actually do want to snapshot and thin it.

@digitalsignalperson
Copy link
Contributor Author

I can work around by using --set-properties autobackup:testdata=true to always make source local on received, independent of this local-only snapshot command.

@psy0rz
Copy link
Owner

psy0rz commented Jun 21, 2022

this is has to do with the use case of local backups and how zfs-autobackup should determine what datasets are source or target.

@psy0rz
Copy link
Owner

psy0rz commented Jun 21, 2022

if think if your specify a --ssh-target, which can be any random host since its not used, youll be fine

@psy0rz psy0rz closed this as completed in defbc2d Sep 26, 2023
@psy0rz
Copy link
Owner

psy0rz commented Sep 26, 2023

well i couldnt think of anything better than to add an --include-received option to overule this behaviour. :)
(generally most users want the automatic enabling of --exclude-received, so we let it in for now)

@psy0rz
Copy link
Owner

psy0rz commented Sep 24, 2024

this probably wont be an issue anymore in v3.4: we now filter the autobackup: property to prevent confusion.

(also that --include-received option has been removed in v3.4.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants