Implement Issue #245 Snapshot exclude patterns #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@psy0rz I just wanted to get early feedback if this approach seems reasonable. I know you don't have much time to implement it yourself, so worst case i'll just use my own patched version on my server for the time being. |
|
looks good, but "is_exluded" is too generic a name i think? |
|
uh oohh some tests failed? |
|
oh nevermind they were already broken, i'll have to fix that first |
|
i fixed all the tests, can you rebase on master so that we can run the tests? |
exi
force-pushed
the
snapshot_exclude_245
branch
from
c433c18 to
67f6f37
Compare
|
@psy0rz rebased ✅ |
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #245
This is mostly a first draft without tests, but it seems to work and i'm using these changes on top of v3.2.2 on my server.
The primary point why I needed this is because in the time zfs_autobackup runs, my zfs-autosnapshot has taken and removed multiple "frequent" snapshots, which leads to autobackup failures.
I just want autobackup the snapshots with "monthly", "weekly" and "daily" in the name.