Generate wrapper objects for extension resources #629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit moves the xproto resource to an extra module and changes the type to not contain a fixed-size array. This is both in preparation for also adding information about extension resources. Signed-off-by: Uli Schlachter <psychon@znc.in>
Signed-off-by: Uli Schlachter <psychon@znc.in>
Signed-off-by: Uli Schlachter <psychon@znc.in>
xfixes adds the Region type. A region can also be created via composite's CreateRegionFromBorderClip. The wrapper for this type is also added on RegionWrapper. Signed-off-by: Uli Schlachter <psychon@znc.in>
Signed-off-by: Uli Schlachter <psychon@znc.in>
Signed-off-by: Uli Schlachter <psychon@znc.in>
6 tasks
error: called `.as_ref().map(|ns| &**ns)` on an Option value. This can be done more directly by calling `request_ns.as_deref()` instead
--> generator/src/generator/namespace/resource_wrapper.rs:172:22
|
172 | let request_ns = request_ns.as_ref().map(|ns| &**ns).unwrap_or(generator.ns);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try using as_deref instead: `request_ns.as_deref()`
|
= note: `-D clippy::option-as-ref-deref` implied by `-D warnings`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_as_ref_deref
Signed-off-by: Uli Schlachter <psychon@znc.in>
str::split_once() was stabilised in Rust 1.52.0. Thus, we cannot use it with our minimum supported rust version of 1.41 and need to reimplement it ourselves. Yay. Signed-off-by: Uli Schlachter <psychon@znc.in>
error: this expression borrows a reference (`&xcbgen::defs::Module`) that is immediately dereferenced by the compiler --> generator/src/generator/mod.rs:57:13 | 57 | &module, | ^^^^^^^ help: change this to: `module` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow Signed-off-by: Uli Schlachter <psychon@znc.in>
psychon
force-pushed
the
generate-wrappers2
branch
from
5d764cf
to
3e86556
Compare
eduardosm
approved these changes
Jul 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of just generating wrappers just for xproto, this PR also implements wrappers damage, record, render, shm, sync, and xfixes. At least the part of those that fits in the current scheme.
Fixes: #78