Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nodes_within_range #49

Merged
merged 1 commit into from
Aug 29, 2021
Merged

Fix nodes_within_range #49

merged 1 commit into from
Aug 29, 2021

Conversation

blegat
Copy link
Contributor

@blegat blegat commented Aug 27, 2021

Fixes a few issues:

  • network is not defined
  • collect gives you a Vector{Int} which has two issues:
    • It is not a subtype of AbstractSet{Int}, we could change the signature
    • Since we just want to iterate once over it, it's a waste to collect
  • If node_list is an AbstractSet, we should collect in case range is Inf since in the other case, it returns a vector

@pszufe pszufe merged commit ae09eed into pszufe:master Aug 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants