Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump LibExpat for LibExpat_jll binary support #60

Merged
merged 4 commits into from
Feb 23, 2022

Conversation

jeremiahpslewis
Copy link
Contributor

No description provided.

@pszufe
Copy link
Owner

pszufe commented Feb 23, 2022

Hi,
thanks for that, however unit tests for ProtoBuf are failing ugly after this update.
Could you have a look?
https://app.travis-ci.com/github/pszufe/OpenStreetMapX.jl/jobs/560852995

@jeremiahpslewis
Copy link
Contributor Author

@pszufe thanks for the feedback! In order to keep this PR focused on libexpat (and given that after looking into the protobuf issue, the fix seems extensive and unfamiliar), I've dropped the version bump on protobuf

@jeremiahpslewis
Copy link
Contributor Author

Note: although this isn't expressly covered by the project CI, the PR passed on Mac OS Apple Silicon, Julia 1.7 :)

@pszufe
Copy link
Owner

pszufe commented Feb 23, 2022

I used to run Travis on MacOS. However at some point they change the rules.
Now there is credit budget for Open Source projects for CI. The problem is that MacOS eats 20x as much of budget as Linux. So when I run CI on MacOS I end up not being able to run Travis unit tests at all.
Thanks for the PR!

@pszufe pszufe merged commit c08f636 into pszufe:master Feb 23, 2022
@jeremiahpslewis
Copy link
Contributor Author

Thank you for the quick review and merge! :)

@jeremiahpslewis jeremiahpslewis deleted the patch-1 branch February 23, 2022 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants