Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed some typos: BOX64 -> BOX86 #1011

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

MikeWang000000
Copy link
Contributor

No description provided.

@@ -206,7 +206,7 @@ Handling of x87 80bits long double
* 0 : Try to handle 80bits long double as precise as possible (Default)
* 1 : Handle them as double

#### BOX64_MAXCPU
#### BOX86_MAXCPU
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ref:

ENTRYINTPOS(BOX86_MAXCPU, new_maxcpu) \

@@ -761,7 +761,7 @@ void LoadLogEnv()
if(box86_showbt)
printf_log(LOG_INFO, "Show Backtrace for signals\n");
}
p = getenv("BOX64_MAXCPU");
p = getenv("BOX86_MAXCPU");
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ref:

ENTRYINTPOS(BOX86_MAXCPU, new_maxcpu) \

@@ -903,8 +903,8 @@ void PrintFlags() {
printf(" BOX86_LIBGL=libXXXX set the name (and optionnaly full path) for libGL.so.1\n");
printf(" BOX86_LD_PRELOAD=XXXX[:YYYYY] force loading XXXX (and YYYY...) libraries with the binary\n");
printf(" BOX86_ALLOWMISSINGLIBS with 1 to allow to continue even if a lib is missing (unadvised, will probably crash later)\n");
printf(" BOX64_PREFER_EMULATED=1 to prefer emulated libs first (execpt for glibc, alsa, pulse, GL, vulkan and X11)\n");
printf(" BOX64_PREFER_WRAPPED if box86 will use wrapped libs even if the lib is specified with absolute path\n");
printf(" BOX86_PREFER_EMULATED=1 to prefer emulated libs first (execpt for glibc, alsa, pulse, GL, vulkan and X11)\n");
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ref:

box86/src/main.c

Line 1027 in 30c72e2

READENV1("BOX86_PREFER_EMULATED", box86_prefer_emulated, "BOX86: Prefer Emulated libs\n");

@@ -1321,7 +1321,7 @@ int main(int argc, const char **argv, char **env)

// check BOX86_LOG debug level
LoadLogEnv();
if(!getenv("BOX64_NORCFILES")) {
if(!getenv("BOX86_NORCFILES")) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ref:

#### BOX86_NORCFILES

printf(" BOX64_PREFER_EMULATED=1 to prefer emulated libs first (execpt for glibc, alsa, pulse, GL, vulkan and X11)\n");
printf(" BOX64_PREFER_WRAPPED if box86 will use wrapped libs even if the lib is specified with absolute path\n");
printf(" BOX86_PREFER_EMULATED=1 to prefer emulated libs first (execpt for glibc, alsa, pulse, GL, vulkan and X11)\n");
printf(" BOX86_PREFER_WRAPPED if box86 will use wrapped libs even if the lib is specified with absolute path\n");
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ref:

box86/src/main.c

Line 1026 in 30c72e2

READENV1("BOX86_PREFER_WRAPPED", box86_prefer_wrapped, "BOX86: Prefer Wrapped libs\n");

@@ -110,7 +110,7 @@ IGNORE(BOX86_DYNAREC_X87DOUBLE) \
IGNORE(BOX86_DYNAREC_FASTNAN) \
IGNORE(BOX86_DYNAREC_FASTROUND) \
IGNORE(BOX86_DYNAREC_SAFEFLAGS) \
IGNORE(BOX64_DYNAREC_CALLRET) \
IGNORE(BOX86_DYNAREC_CALLRET) \
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ref:

p = getenv("BOX86_DYNAREC_CALLRET");

@MikeWang000000
Copy link
Contributor Author

Some environment variables like BOX86_NORCFILES did not work because of typos. From now it will work.

@ptitSeb
Copy link
Owner

ptitSeb commented Nov 6, 2024

nice, thnaks.

@ptitSeb ptitSeb merged commit 450347f into ptitSeb:master Nov 6, 2024
36 checks passed
@MikeWang000000 MikeWang000000 deleted the fix-typo-box86 branch November 6, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants