Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes some changes & fixes to the Arch Linux PKGBUILD for the RK3399:
package()
step;-DCMAKE_INSTALL_PREFIX=/usr
using CMake, so that the step moving the files from/usr/local
is no longer necessary. This also fixes the/etc/binfmt.d/box86.conf
file, which otherwise still points to/usr/local/bin/box86
.cmake
as part of the build, instead of in the prepare stage, and runs it using the-B ... -S
options, as recommended in https://wiki.archlinux.org/title/CMake_package_guidelines#Specifying_directories-j
flag frommake
, as in Arch Linux this is something that is normally set viaMAKEFLAGS
in makepkg.conf instead.I think it could be a good idea to repeat these changes for the other pkgbuild files - the
-DCMAKE_INSTALL_PREFIX
one in particular.