Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rk3399 PKGBUILD #542

Merged
merged 1 commit into from
Jan 5, 2022
Merged

Fix rk3399 PKGBUILD #542

merged 1 commit into from
Jan 5, 2022

Conversation

asppsa
Copy link
Contributor

@asppsa asppsa commented Jan 5, 2022

This PR makes some changes & fixes to the Arch Linux PKGBUILD for the RK3399:

  • Fixes an apparent copy-paste mistake in the package() step;
  • Sets -DCMAKE_INSTALL_PREFIX=/usr using CMake, so that the step moving the files from /usr/local is no longer necessary. This also fixes the /etc/binfmt.d/box86.conf file, which otherwise still points to /usr/local/bin/box86.
  • Runs cmake as part of the build, instead of in the prepare stage, and runs it using the -B ... -S options, as recommended in https://wiki.archlinux.org/title/CMake_package_guidelines#Specifying_directories
  • Removes the -j flag from make, as in Arch Linux this is something that is normally set via MAKEFLAGS in makepkg.conf instead.

I think it could be a good idea to repeat these changes for the other pkgbuild files - the -DCMAKE_INSTALL_PREFIX one in particular.

@ptitSeb
Copy link
Owner

ptitSeb commented Jan 5, 2022

I think it could be a good idea to repeat these changes for the other pkgbuild files - the -DCMAKE_INSTALL_PREFIX one in particular.

Yes, that would probably be a good idea. Can you do it?

@ptitSeb ptitSeb merged commit 44d6719 into ptitSeb:master Jan 5, 2022
@asppsa
Copy link
Contributor Author

asppsa commented Jan 5, 2022

Yes, that would probably be a good idea. Can you do it?

Yep, sure.

@asppsa asppsa deleted the pkgbuild-fix branch January 5, 2022 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants