Set rounding mode for some rounding functions of libm #953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit rewrites fesetround and fegetround to set and get the
rounding mode in x86emu, and applies the rounding mode on rounding
functions (`{,l,ll}rint{,f,l}` and `nearbyint{,f,l}`).
|
Well I have a question. What is meant by "weak" for a symbol map? And in which situation should we use a weak map? |
This is a linker thing. That means the symbols can be overriden by one from another library basicaly. There is no simple way to know wich symbol is weak, you need to look at the original libs symbol for that. |
ptitSeb
reviewed
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR rewrites fesetround and fegetround to set and get the rounding mode in x86emu, and applies the rounding mode on rounding functions (
{,l,ll}rint{,f,l}andnearbyint{,f,l}). Test24 (feround) can pass with this patch.The rounding mode can also be applied on other math functions if needed.