Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indexed fields are automatically marked as required #620

Closed
gvuyk opened this issue Apr 25, 2018 · 2 comments
Closed

Indexed fields are automatically marked as required #620

gvuyk opened this issue Apr 25, 2018 · 2 comments

Comments

@gvuyk
Copy link
Contributor

gvuyk commented Apr 25, 2018

Fields marked with index: true are automatically added to the the list of "required" fields, preventing the insertion of new documents that don't provide that field. AFAIK nor CouchDb or PouchDb have such limitation and I didn't find a feature here that requires it

Removed the code causing it so I can create better indexes, my app is way faster now 😃
Going to create a PR with a test case and a possible fix (a few deletions)

@pubkey
Copy link
Owner

pubkey commented Apr 25, 2018

Hi @gvuyk
The PR looks good, thank you.
The CI fails randomly atm, I will restart until it works :)

@pubkey
Copy link
Owner

pubkey commented Apr 25, 2018

I merged the PR. Thank you very much.

pubkey added a commit that referenced this issue Apr 25, 2018
@gvuyk gvuyk closed this as completed Apr 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants