Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix spelling of recieved => received #3392

Merged
merged 2 commits into from
Sep 20, 2021
Merged

fix spelling of recieved => received #3392

merged 2 commits into from
Sep 20, 2021

Conversation

chrisdrackett
Copy link
Contributor

This PR contains:

  • SOMETHING ELSE

Describe the problem you have without this PR

Fixing misspelled recieved -> received

Because this touches code I think its a breaking change.

Todos

  • Tests
  • Documentation
  • Typings
  • Changelog

@pubkey
Copy link
Owner

pubkey commented Sep 16, 2021

Thank you. Yes this would be a breaking change.
We could add both getters recieved$ and received$ and add a deprecation warning to the wrong one. Then we can remove the deprecated getter in the next major version.

@chrisdrackett
Copy link
Contributor Author

@pubkey updated!

@pubkey pubkey merged commit c058b9f into pubkey:master Sep 20, 2021
pubkey added a commit that referenced this pull request Sep 20, 2021
@pubkey
ADD(changelog) #3392
7df5e13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chrisdrackett @pubkey