ICS721 v2: cw721 v19 with creator and onchain extensioms (aka metadata) #103
Conversation
taitruong
changed the title
taitruong
changed the title
| &cw721_base::msg::QueryMsg::<Empty>::ContractInfo {}, | ||
| #[allow(deprecated)] | ||
| // For now we use `ContractInfo` which is known across all version, whilst `GetCollectionInfoAndExtension` is only available in v0.19 and higher | ||
| &cw721_metadata_onchain::msg::QueryMsg::ContractInfo {}, |
There was a problem hiding this comment.
This is where collection metadata is retrieved. cw721 v18 and below only holds name and symbol. Whilst v19 holds creator and royalty info.
| let royalty_info = collection_info.royalty_info.map(|r| RoyaltyInfo { | ||
| payment_address: Addr::unchecked(r.payment_address), | ||
| share: r.share, | ||
| }); | ||
| let extension = Some(CollectionExtension { | ||
| description: collection_info.description, | ||
| image: collection_info.image, | ||
| external_link: collection_info.external_link, | ||
| explicit_content: collection_info.explicit_content, | ||
| start_trading_time: collection_info.start_trading_time, | ||
| royalty_info, | ||
| }); |
There was a problem hiding this comment.
Here sg-ics721 overrides default implementation and gets collection data from sg721-base via CollectionInfo query.
| let collection_info_extension_msg = | ||
| collection_data | ||
| .extension | ||
| .map(|ext| cw721::msg::CollectionExtensionMsg { | ||
| description: Some(ext.description), | ||
| image: Some(ext.image), | ||
| external_link: ext.external_link, | ||
| explicit_content: ext.explicit_content, | ||
| start_trading_time: ext.start_trading_time, | ||
| royalty_info: ext.royalty_info.map(|r| RoyaltyInfoResponse { | ||
| payment_address: cw721_admin_or_ics721_admin_or_ics721_creator, // r.payment_address cant be used, since it is from another chain | ||
| share: r.share, | ||
| }), | ||
| }); | ||
| instantiate_msg.collection_info_extension = collection_info_extension_msg; |
There was a problem hiding this comment.
on ibc receive for initial transfer, collection extension is passed to cw721 instantiate message.
| // incase there is none in the storage, this is the 'home' chain, so metadata is retrieved from the cw721 contract | ||
| None => info.extension.map(|ext| to_json_binary(&ext)).transpose()?, |
There was a problem hiding this comment.
Here, on source chain, nft extension (metadata) is retrieved and passed in ibc packet.
| // parse token data and check whether it is of type NftExtension | ||
| let extension: Option<NftExtensionMsg> = match data { | ||
| Some(data) => from_json::<NftExtension>(data) | ||
| .ok() | ||
| .map(|ext| NftExtensionMsg { | ||
| animation_url: ext.animation_url, | ||
| attributes: ext.attributes, | ||
| background_color: ext.background_color, | ||
| description: ext.description, | ||
| external_url: ext.external_url, | ||
| image: ext.image, | ||
| image_data: ext.image_data, | ||
| youtube_url: ext.youtube_url, | ||
| name: ext.name, | ||
| }), | ||
| None => None, | ||
| }; |
There was a problem hiding this comment.
On receive, ics721 checks whether ibc packet holds nft extensions - if so NFT is minted with onchain metadata.
| t.deepEqual( | ||
| wasmCollectionData, | ||
| osmoCollectionData, | ||
| `collection data must match: ${JSON.stringify( | ||
| wasmCollectionData | ||
| )} vs ${JSON.stringify(osmoCollectionData)}` | ||
| ); |
There was a problem hiding this comment.
integration check whether collection extension on target chain matches with source chain
| const osmoNftInfo = await nftInfo(osmoClient, osmoCw721, tokenId); | ||
| t.truthy(osmoNftInfo.extension); | ||
| // assert nft with extension is same | ||
| t.deepEqual(wasmNftInfo, osmoNftInfo); |
There was a problem hiding this comment.
check for nft onchain metadata
| @@ -746,6 +847,471 @@ test.serial("transfer NFT: wasmd -> osmo", async (t) => { | |||
| t.is(wasmAddr, tokenOwner.owner); | |||
| }); | |||
|
|
|||
| test.serial("transfer NFT v16: wasm -> osmo", async (t) => { | |||
There was a problem hiding this comment.
same test, but with cw721 v16 on source chain
| t.deepEqual( | ||
| wasmCollectionData.name, | ||
| osmoCollectionData.name, | ||
| `name must match: ${wasmCollectionData.name} vs ${osmoCollectionData.name}` | ||
| ); |
There was a problem hiding this comment.
cw721 only holds name and symbole in collection extension
| const osmoNftInfo = await nftInfo(osmoClient, osmoCw721, tokenId); | ||
| t.truthy(osmoNftInfo.extension); | ||
| // assert nft with extension is same | ||
| t.deepEqual(wasmNftInfo, osmoNftInfo); |
There was a problem hiding this comment.
cw721 v16 and higher holds same nft extension (as defined by erc721 spec).
This is ics721 v2 using cw721 v19 (includes collection extension (metadata) and creator):