Mode proposal #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 2, 2017 14:56
derhuerst
reviewed
Mar 2, 2017
docs/readme.md
Outdated
| - `train` | ||
| - `bus` - local traffic | ||
| - `coach` - long-distance traffic |
There was a problem hiding this comment.
What is the distinction between local traffic and long-distance traffic, especially in other countries?
There was a problem hiding this comment.
I would use this definition. If you can actually call that a definition 😛
There was a problem hiding this comment.
Fair enough. Still, I'd opt for the more general bus with an additional field indicating that it's long-distance.
There was a problem hiding this comment.
Ok, I'm fine with that. Especially since it would be inconsequent to have different modes for buses but not for trains. But that's where things would get really messy, so let's keep the modes as broad as possible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@derhuerst Opinions?