mark subMode as reserved #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derhuerst
commented
Nov 28, 2017
| - `train` – high-speed, regional, commuter/urban & underground trains | ||
| The following list shows all possible values for a `mode` property. For consumers to be able to use `mode` meaningfully, we will keep this list very short. | ||
|
|
||
| - `train` |
There was a problem hiding this comment.
I would like to have helpful descriptions for these, just like the two I deleted ("urban & long-distance water transport"). @juliuste @kiliankoe please make proposals.
|
Sorry for not weighing in on this earlier. I'd like to keep my opinion out of this, as you guys seem to have a much better understanding of the intricacies of transport modes and what the different terms imply. |
|
@kiliankoe Okay. Didn't mean to push you off by sounding too "involved" with public transport. Feel welcome to participate whenever you feel like a point is not being addressed! |
juliuste
approved these changes
Dec 11, 2017
derhuerst
added a commit
to public-transport/validate-fptf
that referenced
this pull request
Dec 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #4, the way to get a release out soon is to mark
subModeas reserved for now and specify possible values in the future.