Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rotation API #579

Merged
merged 3 commits into from
Mar 29, 2020
Merged

Rotation API #579

merged 3 commits into from
Mar 29, 2020

Conversation

sashadev-sky
Copy link
Member

@sashadev-sky sashadev-sky commented Mar 29, 2020

Fixes #0000 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with grunt
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updates
  • @mention the original creator of the issue in a comment below for help or for a review

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

UPDATES:

=====================

  • update eslint to recognize es6
  • update jshint to recognize es6
  • standardize use of #rotateBy, #getAngle, and #setAngle and expose to API
  • specs for #rotateBy, #getAngle, and #setAngle
  • general cleaning
  • fix lint warnings
  • add a rotation option for L.distortableImageOverlay and expose to API
  • add test script to package.json
  • bump version to "0.13.6"

=====================

@sashadev-sky sashadev-sky force-pushed the rotation-prop branch 2 times, most recently from 156d60b to f57adcd Compare March 29, 2020 04:18
@sashadev-sky sashadev-sky changed the title Rotation prop Rotation API Mar 29, 2020
@sashadev-sky
Copy link
Member Author

@VladimirMikulic was meaning to push this a while ago when you added the getAngle and setAngle methods, then cleaned up some other things. Please see PR description and lmk if it's good to merge!

Copy link
Contributor

@VladimirMikulic VladimirMikulic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, great job, the changes work 👍

@sashadev-sky
Copy link
Member Author

@VladimirMikulic thanks for the quick review, i'll merge now!

I made that post related to _calculateProjectiveTransform btw: https://publiclab.org/notes/sashadev-sky/03-28-2020/if-you-don-t-know-about-georectification#.

Would you be interested in adding anything on? I can add you as a co-author if so, I just need your PL username.

@sashadev-sky sashadev-sky merged commit 3b80a0b into publiclab:main Mar 29, 2020
@VladimirMikulic
Copy link
Contributor

@sashadev-sky you can just specify my Github profile :)

@sashadev-sky
Copy link
Member Author

@VladimirMikulic i think it unfortunately needs to be a PL account, its that new co-author feature on the website. Do you not have a PL account?

@VladimirMikulic
Copy link
Contributor

No, I don't. Anyway, it doesn't matter :)

@sashadev-sky
Copy link
Member Author

@VladimirMikulic ok np! U should make one tho! Its fun to get involved on there too with coding updates
and SoC proposals.

sashadev-sky added a commit that referenced this pull request Apr 13, 2020
* Audit package-lock

* Update rotation angle setters and getters
sashadev-sky added a commit to carlo-ev/Leaflet.DistortableImage that referenced this pull request Apr 14, 2020
* Audit package-lock

* Update rotation angle setters and getters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants