-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rotation API #579
Rotation API #579
Conversation
156d60b
to
f57adcd
Compare
dae38fd
to
509d859
Compare
@VladimirMikulic was meaning to push this a while ago when you added the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, great job, the changes work 👍
@VladimirMikulic thanks for the quick review, i'll merge now! I made that post related to Would you be interested in adding anything on? I can add you as a co-author if so, I just need your PL username. |
@sashadev-sky you can just specify my Github profile :) |
@VladimirMikulic i think it unfortunately needs to be a PL account, its that new co-author feature on the website. Do you not have a PL account? |
No, I don't. Anyway, it doesn't matter :) |
@VladimirMikulic ok np! U should make one tho! Its fun to get involved on there too with coding updates |
* Audit package-lock * Update rotation angle setters and getters
* Audit package-lock * Update rotation angle setters and getters
Fixes #0000 (<=== Add issue number here)
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
grunt
If tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!
UPDATES:
=====================
#rotateBy
,#getAngle
, and#setAngle
and expose to API#rotateBy
,#getAngle
, and#setAngle
rotation
option forL.distortableImageOverlay
and expose to APItest
script to package.json=====================