Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for notify() #686

Merged
merged 4 commits into from
Jan 22, 2019
Merged

Add tests for notify() #686

merged 4 commits into from
Jan 22, 2019

Conversation

Divy123
Copy link
Member

@Divy123 Divy123 commented Jan 18, 2019

Fixes #[Add issue number here.]

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with npm test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • ask @publiclab/is-reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@Divy123 Divy123 requested a review from jywarren January 18, 2019 14:33
@Divy123
Copy link
Member Author

Divy123 commented Jan 22, 2019

@jywarren please review.

@jywarren
Copy link
Member

Awesome!!!

@jywarren jywarren merged commit 8fd4efc into publiclab:main Jan 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants