Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hide grid overlay controls on initial display #259

Closed
6 tasks
first-timers bot opened this issue Mar 29, 2022 · 4 comments Β· Fixed by #308
Closed
6 tasks

hide grid overlay controls on initial display #259

first-timers bot opened this issue Mar 29, 2022 · 4 comments Β· Fixed by #308

Comments

@first-timers
Copy link

first-timers bot commented Mar 29, 2022

πŸ†•πŸ₯☝ First Timers Only.

This issue is reserved for people who never contributed to Open Source before. We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you πŸ’

About First Timers Only.

πŸ€” What you need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

πŸ“‹ Step by Step

  • πŸ™‹ Claim this issue: Comment below.

    Once claimed we add you as contributor to this repository.

  • πŸ‘Œ Accept our invitation to this repository. Once accepted, assign yourself to this issue

  • πŸ“ Update the file \index.html in the infragram repository (press the little pen Icon) and edit the line as shown below.

@@ -156,7 +156,7 @@ <h1><img src="assets/infragram-logo.png" alt="Infragram logo image." style="floa
                   <i class="fa fa-th" aria-hidden="true"></i>
                 </button>
               </div>
-              <div class="col-md-8" id="overlay-controls-container">
+              <div class="col-md-8" id="overlay-controls-container" style="display:none;">
                 <input id="overlay-slider" type="range" min="10" max="50" value="100"/>
                 <span id="overlay-size" style="color:#ccc;"></span>
                 <button id="overlay-save-btn" class="btn btn-primary">Save</button>
  • πŸ’Ύ Commit your changes

  • πŸ”€ Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can edit files directly in your browser

  • 🏁 Done Ask in comments for a review :)

πŸ€”β“ Questions

Leave a comment below!

This issue was created by First-Timers-Bot.

@jywarren
Copy link
Member

This change will make the slider and "save" button next to the Grid Overlay button hidden until the button is pressed!

image

@jywarren
Copy link
Member

This issue is reserved for @Hydriah, thanks!

@Bhawna-Sharma-9903
Copy link

hello can I work on this issue?

@Hydriah
Copy link
Contributor

Hydriah commented Apr 2, 2022

@jywarren @TildaDares just created a pull request on this issue

Hydriah added a commit to Hydriah/infragram that referenced this issue Apr 2, 2022
@TildaDares TildaDares linked a pull request Apr 3, 2022 that will close this issue
@jywarren jywarren mentioned this issue Jun 22, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants