Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added comments + Fixed indentations #200

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

anushkachauhxn
Copy link

@anushkachauhxn anushkachauhxn commented Mar 3, 2022

Added comments + Fixed indentations in index.html file

@welcome
Copy link

welcome bot commented Mar 3, 2022

Thanks for opening this pull request! Dangerbot will test out your code and reply in a bit with some pointers and requests.
There may be some errors, but don't worry! We're here to help! 👍🎉😄

@gitpod-io
Copy link

gitpod-io bot commented Mar 3, 2022

@TildaDares
Copy link
Member

Hi @anushkachauhxn, can you add a link to the issue you're resolving? You can add it in the format Fixes #0000. Thanks!

@anushkachauhxn
Copy link
Author

Hi @TildaDares, this is a simple enhancement to the code. Should I create a new issue for this?

@TildaDares
Copy link
Member

Never mind, I understand what you did.

@TildaDares
Copy link
Member

Hi @anushkachauhxn, this PR is on hold because we plan on redesigning the Infragram homepage as an Outreachy project https://publiclab.org/wiki/gsoc-ideas#Outreachy:+Infragram.org+full-screen+UI+design. You can open an issue that lists all of the things you plan to change/redesign along with wireframes/sketches if you want to work on this project. This list/note will serve as your proposal to work on this project.

If you don't plan on working on this project, you can make suggestions or discuss improvements you think should be made to the Infragram UI in our project discussion issue publiclab/plots2#10754.

We appreciate your contributions to Public Lab. Thank you!

@TildaDares TildaDares added the on-hold There is a temporary hold on any continued work or review. label Mar 7, 2022
@anushkachauhxn
Copy link
Author

I'll do that. Thank you so much!

@anushkachauhxn
Copy link
Author

@TildaDares Can I continue with this pull request as an Outreachy Contributor now? Also, should I open a new issue for this?

@TildaDares
Copy link
Member

Hi @anushkachauhxn, the UI infragram design project will change a lot of code so if you refactor it now, it’ll be completely lost when the internship starts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
on-hold There is a temporary hold on any continued work or review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants