Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Sample Images to Output Section #419

Merged
merged 3 commits into from
Jun 21, 2022
Merged

Added Sample Images to Output Section #419

merged 3 commits into from
Jun 21, 2022

Conversation

stephaniequintana
Copy link
Collaborator

Updated README.md to include sample images.

Screen Shot 2022-06-15 at 4 42 14 AM

Fixes #0000
No issue was created for this PR.
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

Added  sample images to Output section
@gitpod-io
Copy link

gitpod-io bot commented Jun 15, 2022

@stephaniequintana
Copy link
Collaborator Author

I placed the images in the Output section, although I believe they could also serve well in the Infragrammar section (or others). Also, I'm not super keen on the table borders, please let me know your opinion. All of this can be addressed as we update the document to reflect the project changes as well.

README.md Outdated

| ![](https://storage.googleapis.com/publiclab-production/public/system/images/photos/000/018/533/thumb/Rosco_26_filtered.JPG) | ![](https://storage.googleapis.com/publiclab-production/public/system/images/photos/000/001/647/thumb/IMG_0025.JPG) |
|:--:| :--:|
| *by [@mathew](https://publiclab.org/profile/mathew) - try processing [this image](https://storage.googleapis.com/publiclab-production/public/system/images/photos/000/018/533/thumb/Rosco_26_filtered.JPG) on [Infragram](https://infragram.org/sandbox/index.html)* | *by [@warren](https://publiclab.org/profile/warren) - try processing [this image](https://storage.googleapis.com/publiclab-production/public/system/images/photos/000/001/647/thumb/IMG_0025.JPG) on [Infragram](https://infragram.org/sandbox/index.html).*|
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!! How about we specify the type of filter, just to be extra clear? Like this -

Suggested change
| *by [@mathew](https://publiclab.org/profile/mathew) - try processing [this image](https://storage.googleapis.com/publiclab-production/public/system/images/photos/000/018/533/thumb/Rosco_26_filtered.JPG) on [Infragram](https://infragram.org/sandbox/index.html)* | *by [@warren](https://publiclab.org/profile/warren) - try processing [this image](https://storage.googleapis.com/publiclab-production/public/system/images/photos/000/001/647/thumb/IMG_0025.JPG) on [Infragram](https://infragram.org/sandbox/index.html).*|
| *A red-filtered image by [@mathew](https://publiclab.org/profile/mathew) - try processing [this image](https://storage.googleapis.com/publiclab-production/public/system/images/photos/000/018/533/thumb/Rosco_26_filtered.JPG) on [Infragram](https://infragram.org/sandbox/index.html)* | *A blue-filtered image by [@warren](https://publiclab.org/profile/warren) - try processing [this image](https://storage.googleapis.com/publiclab-production/public/system/images/photos/000/001/647/thumb/IMG_0025.JPG) on [Infragram](https://infragram.org/sandbox/index.html).*|

Great addition, @jywarren - this'll come in handy when including them as samples on the sandbox page, too.
Copy link
Member

@jywarren jywarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - would you like to try merging this, partially just to confirm that you have permissions to do so? I'd still like to be sure we get approvals as a matter of workflow policy, but it's good to confirm that you technically have the permission to do a merge. Thanks!

@stephaniequintana
Copy link
Collaborator Author

I would like to, but I'm not see an option to do so. I am getting a message that "Only those with write access to this repository can merge.."

@jywarren
Copy link
Member

Hi, i'm sorry i tried responding but it didn't go through. I have updated permissions on this project, would you mind trying again? Thank you!

@jywarren jywarren mentioned this pull request Jun 21, 2022
@jywarren jywarren merged commit 4b23dab into publiclab:main Jun 21, 2022
@welcome
Copy link

welcome bot commented Jun 21, 2022

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to http://infragram.org in the next few days.
Now that you've completed this, you can help someone else take their first step!
See: Public Lab's coding community!

@jywarren jywarren mentioned this pull request Jun 22, 2022
5 tasks
@jywarren
Copy link
Member

jywarren commented Oct 11, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants