-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Sample Images to Output Section #419
Conversation
Added sample images to Output section
I placed the images in the Output section, although I believe they could also serve well in the Infragrammar section (or others). Also, I'm not super keen on the table borders, please let me know your opinion. All of this can be addressed as we update the document to reflect the project changes as well. |
README.md
Outdated
|
||
| ![](https://storage.googleapis.com/publiclab-production/public/system/images/photos/000/018/533/thumb/Rosco_26_filtered.JPG) | ![](https://storage.googleapis.com/publiclab-production/public/system/images/photos/000/001/647/thumb/IMG_0025.JPG) | | ||
|:--:| :--:| | ||
| *by [@mathew](https://publiclab.org/profile/mathew) - try processing [this image](https://storage.googleapis.com/publiclab-production/public/system/images/photos/000/018/533/thumb/Rosco_26_filtered.JPG) on [Infragram](https://infragram.org/sandbox/index.html)* | *by [@warren](https://publiclab.org/profile/warren) - try processing [this image](https://storage.googleapis.com/publiclab-production/public/system/images/photos/000/001/647/thumb/IMG_0025.JPG) on [Infragram](https://infragram.org/sandbox/index.html).*| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!! How about we specify the type of filter, just to be extra clear? Like this -
| *by [@mathew](https://publiclab.org/profile/mathew) - try processing [this image](https://storage.googleapis.com/publiclab-production/public/system/images/photos/000/018/533/thumb/Rosco_26_filtered.JPG) on [Infragram](https://infragram.org/sandbox/index.html)* | *by [@warren](https://publiclab.org/profile/warren) - try processing [this image](https://storage.googleapis.com/publiclab-production/public/system/images/photos/000/001/647/thumb/IMG_0025.JPG) on [Infragram](https://infragram.org/sandbox/index.html).*| | |
| *A red-filtered image by [@mathew](https://publiclab.org/profile/mathew) - try processing [this image](https://storage.googleapis.com/publiclab-production/public/system/images/photos/000/018/533/thumb/Rosco_26_filtered.JPG) on [Infragram](https://infragram.org/sandbox/index.html)* | *A blue-filtered image by [@warren](https://publiclab.org/profile/warren) - try processing [this image](https://storage.googleapis.com/publiclab-production/public/system/images/photos/000/001/647/thumb/IMG_0025.JPG) on [Infragram](https://infragram.org/sandbox/index.html).*| |
Great addition, @jywarren - this'll come in handy when including them as samples on the sandbox page, too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - would you like to try merging this, partially just to confirm that you have permissions to do so? I'd still like to be sure we get approvals as a matter of workflow policy, but it's good to confirm that you technically have the permission to do a merge. Thanks!
I would like to, but I'm not see an option to do so. I am getting a message that "Only those with write access to this repository can merge.." |
Hi, i'm sorry i tried responding but it didn't go through. I have updated permissions on this project, would you mind trying again? Thank you! |
Congrats on merging your first pull request! 🙌🎉⚡️ |
Oh ok... I adjusted the privileges... Can you now? Thanks!!
…On Fri, Jun 17, 2022, 7:00 PM Stephanie Quintana ***@***.***> wrote:
I would like to, but I'm not see an option to do so. I am getting a
message that "Only those with write access to this repository can merge.."
—
Reply to this email directly, view it on GitHub
<#419 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAF6J5YSO3ECW675XQ5DQ3VPRZHPANCNFSM5Y2UNUPQ>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Updated README.md to include sample images.
Fixes #0000
No issue was created for this PR.
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
@publiclab/reviewers
for help, in a comment below