Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

corrected keyboard-accessibility for input element #435

Merged

Conversation

stephaniequintana
Copy link
Collaborator

On the <input> element - changed display: none; to class="visually-hidden" and added focus to <label> element.
(Utilizing opacity: 0 does not take the element out of the flow and thus caused spacing issues)

This issue is not related to a particular fix#
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

@gitpod-io
Copy link

gitpod-io bot commented Jul 21, 2022

@stephaniequintana
Copy link
Collaborator Author

@jywarren, @TildaDares, @cesswairimu -
Correcting this accessibility issue has helped me to identify other areas that need A11y attention. I will add these to my planning issues.

Copy link
Member

@jywarren jywarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@jywarren jywarren merged commit 86b2ddb into publiclab:main Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants