Process Uploaded Video File Locally #445
Conversation
-Switch between Live Stream and Video File analysis
Added function "options.processLocalVideo()"
-Adapted functions '$("#webcam-activate")' and '$(options.fileSelector)' for Version 1 and Version 2.
-Included function for local video Processing and interactive video controls.
-Included Function for Local Video Processing.
Adapted "$("#webcam-activate")" and "$(options.fileSelector)" functions for both Version 1 and Version 2
|
|
|
Hello @stephaniequintana , Here is the clean PR for video upload and processing. During the drag and drop please drop the video file as Line 42 in 550a2d2 |
|
@jywarren , @TildaDares please for your feedback on this PR |
| @@ -22,7 +22,7 @@ | |||
| <script src="node_modules/webrtc-adapter/out/adapter.js"></script> | |||
| <script src="node_modules/getusermedia-js/dist/getUserMedia.min.js"></script> | |||
|
|
|||
| <script src="dist/infragram2.js"></script> | |||
| <script src="dist/infragram.js"></script> | |||
There was a problem hiding this comment.
Very cool! So do we need to keep dist/infragram2.js now? Just curious, thanks for all the thorough testing! I'd love to hear from @stephaniequintana on this as well, just a review would be helpful! Thank you!
There was a problem hiding this comment.
I think there's no need to keep the dist/infragram2.js file.In the mean time please permit me move forward with the merge.
There was a problem hiding this comment.
@stephaniequintana, your review is very important on this topic. Please I will consider and apply it on the next PR. For now please let me merge this.
There was a problem hiding this comment.
OK, sounds good - @Forchapeatl can you delete dist/infragram2.js in a new PR?
Process Uploaded Video File Locally
Fixes #418
Passed Test case
Found at https://forchapeatl.github.io/infragram/indexs.html#
Switch between image and video file
7ea8b9b1-745a-4d99-8d82-fffa7563a07e.mp4
Switch between camera and video file
ezgif-3-1e26f85df8.mp4
Misc test
ezgif-5-4f445a5226.mp4
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
@publiclab/reviewersfor help, in a comment below