Osm landfill mine quarry #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinzluo
force-pushed
the
osm-landfill-mine-quarry
branch
3 times, most recently
from
8f347be
to
91c0f0c
Compare
sagarpreet-chadha
approved these changes
Dec 3, 2018
| var countLayers = 0; | ||
| for (var key in self._colorOptions) { | ||
| //Generate URL for each type | ||
| var LMQ_url = "http://www.overpass-api.de/api/xapi?*[landuse=" + key + "][bbox=" + (southwest.lng) + "," + (southwest.lat) + "," + (northeast.lng) + "," + (northeast.lat) + "]"; |
| var id = $(this).attr('id'); //Use id as the key | ||
| var nodeLat = $(this).attr('lat'); | ||
| var nodeLng = $(this).attr('lon'); | ||
|
|
kevinzluo
force-pushed
the
osm-landfill-mine-quarry
branch
from
a7535c3
to
f5e3b90
Compare
|
Oops, needs a rebase, i guess! Then should be ready to go! Thank you!! |
Add Quarry and Mines and colors Add comments and remove console.logs Fix spinner Refactor and add clearOutsideBounds
kevinzluo
force-pushed
the
osm-landfill-mine-quarry
branch
from
f5e3b90
to
dba1dd1
Compare
|
Sorry about that. It should be fixed now. |
|
Awesome 👍 ! Merging , THANK YOU 🎉 ! |
|
This PR is breaking the code somewhere .
|
|
Fixed in PR #106 😄 ! |
|
fantastic. This is great!
…On Tue, Dec 18, 2018 at 5:45 AM Sagarpreet Chadha ***@***.***> wrote:
Fixed in PR #106
<#106> 😄 !
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#94 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJ5Pwov-oRG2GlM6QFQ4hcb9oO02xks5u6MdDgaJpZM4Y91jF>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #56
I have added a layer for landfills, mines, and quarries through OSM:
Currently the colors are:
Red for Landfills,
Blue for Mines,
Green for Quarries
As I stated here, I decided to parse the XML instead as the JSON output didn't provided the longitude latitude coordinates.
Currently the map is very slow, as you can see from the gif. It is possible I may have been above the quota. I am not too sure.
I have set the minimum zoom to 7 and clearOutsideBounds to false for now.
Please let me know if you would like me to change anything.
Also, thank you @sagarpreet-chadha . The spinner is super helpful when testing.
Thank you,
Kevin Luo