remove map files post #11225 #11414
remove map files post #11225 #11414
Conversation
|
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #11414 +/- ##
==========================================
+ Coverage 77.14% 83.33% +6.18%
==========================================
Files 96 93 -3
Lines 6051 5772 -279
==========================================
+ Hits 4668 4810 +142
+ Misses 1383 962 -421
|
|
This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here: |
|
This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here: |
…ut map_controller
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| @node = if params[:node_type] == "map" | ||
| # legacy map type converted to notes but preserving paths: | ||
| Node.where(path: "/map/#{params[:name]}/#{params[:date]}").first | ||
| elsif params[:author] && params[:date] && params[:id] |
| Node.where(path: "/map/#{params[:name]}/#{params[:date]}").first | ||
| elsif params[:author] && params[:date] && params[:id] | ||
| Node.find_notes(params[:author], params[:date], params[:id]) || Node.where(path: "/report/#{params[:id]}").first | ||
| else |
| end | ||
| @node = if params[:node_type] == "map" | ||
| # legacy map type converted to notes but preserving paths: | ||
| Node.where(path: "/map/#{params[:name]}/#{params[:date]}").first |
There was a problem hiding this comment.
Use 2 (not -4) spaces for indentation.
|
This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here: |
|
This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here: |
|
Still facing: |
|
map pages work when tested manually in gitpod! Tried reordering the routes. Next could look at docs for functional test routing. |
|
Same error. |
|
This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here: |
|
Code Climate has analyzed commit 19fa210 and detected 4 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
|
This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here: |
|
Hooray! Trying this. |
|
Confirmed working on stable!! |
Fixes #2606 and follows map node conversion to note nodes in #11225