Fix bad reference in node.rb (fixes #2398) #2410
Conversation
| def questions | ||
| # override with a tag like `questions:h2s` | ||
| if self.has_power_tag('questions') | ||
| tagname = self.power_tag('questions') |
There was a problem hiding this comment.
This is the only line that needed to be changed.
|
Thank you @MittalS211 for your first PR. |
|
This may help with removing unneeded changes! |
|
Alright. I'll just go over it and update you.
…On Tue 27 Feb, 2018, 10:36 PM Jeffrey Warren, ***@***.***> wrote:
This may help with removing unneeded changes!
https://stackoverflow.com/questions/215718/reset-or-revert-a-specific-file-to-a-specific-revision-using-git
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2410 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AglmCKIroDAQXk8Kyef4nqx-MeHOMB8_ks5tZDYJgaJpZM4SU0Lx>
.
|
|
@MittalS211 I would like to ask if you are working on a |
| @@ -44,6 +44,9 @@ | |||
| <i class='icon fa fa-trash'></i> | |||
| </a> | |||
| <% end %> | |||
| <a rel="tooltip" title="Flag as spam." class="btn btn-sm btn-default" href="mailto:moderators@publiclab.org?subject=Reporting+spam+on+Public Lab&body=Hi,+I+found+this+item+that+looks+like+spam+or+needs+to+be+moderated:+"<%= comment.body.replace(' ','+') %>"%0A%0Ahttps://publiclab.org/n/<%= node.id %>%0Aby+https://publiclab.org/profile/<%= comment.author.username %>%0A%0AThanks!"> | |||
There was a problem hiding this comment.
These lines look just right. I wonder if you could remove the others from your PR?
Then I think we'll be done here! Thanks so much!
|
Hi @MittalS211 Do you need any help?? |
|
As the person is inactive for more than a month, I am closing the PR. In case you want to push changes please feel free to open a new PR. |
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake testfixes #0000-style reference to original issue #@publiclab/reviewersfor help, in a comment belowIf tests do fail, click on the red
Xto learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.
Thanks!
Fixes #2398