Add test for questions count on methods page

[jywarren]

No description provided.

[PublicLabBot]

	2 Messages
📖	@jywarren Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.
📖	This pull request doesn’t link to a issue number. Please refer to the issue it fixes (if any) in the body of your PR, in the format: Fixes #123.

Generated by 🚫 Danger

[jywarren]

@publiclab/reviewers - this is odd -- our Danger test failures for assert_select seem to be showing this error instead of indicating what was matched/not matched. Has anyone else seen this?

[sagarpreet-chadha]

@jywarren ...see this line :

plots2/app/models/node.rb

Line 777 in 34e78b8

tagname = node.power_tag('questions')

undefined local variable , right ?

[sagarpreet-chadha]

Okay , so i think nodes(:method) does not contains tag method so i added this line :
nodes(:method).add_tag('method', users(:bob)) .

Then i used id instead of class in the <span> tag in _notes.html.erb:44

And then in assert_select i changed to :
assert_select "#questions-count-#{nodes(:method).id}", "#{nodes(:method).questions.count} questions" .

and the test passed ! What do you think ?

[sagarpreet-chadha]

@jywarren ....when i used id instead of class , the travis showed the correct error of what was matched/unmatched.
I guess when we used class then assert_select returns array of classes (in our case array has 1 item) and hence there was a different error earlier.

[jywarren]

Oh, this is awesome. Do you think you could add a commit to this PR?

Thank you so much for helping out! 🙌 🤝

[jywarren]

Oh wow you already did! My browser tab just hadn't refreshed. AMAZING TEAMWORK!!! 🎈🎈🎈🎈🎈🎈🎈🎈🎈