Translation: Put single/double quotes around values in config/locales/controllers files #4751
Conversation
|
@gauravano |
|
Hi @akshaygupta533, thanks for the work. Have you compared the quotes for the entire file or just after the line 756 because there is no change before that in your commit. I ran the PR locally and after running across Google searches, I found the error using YamlLint - https://github.com/adrienverge/yamllint. I am correcting the error. Thanks! |
Generated by 🚫 Danger |
|
@gauravano I just compared the strings in the controller files. If there's anything else to do, let me know. |
|
Yes, comparison has to be done for all the files present in the locales
folder.
…On Mon, Feb 4, 2019 at 6:05 PM Akshay Gupta ***@***.***> wrote:
@gauravano <https://github.com/gauravano> I just compared the strings in
the controller files. If there's anything else to do, let me know.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4751 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AT6S9tow7GKfiY6zUuohDk9ALeY4ffn7ks5vKCkngaJpZM4af9WQ>
.
|
|
Hi @akshaygupta533, is it possible for you to complete this PR by Monday as this combined file has to be tested and uploaded to Transifex too for the Translation & review process to begin? Also, you can update the status here like which folders from the original file structure you have compared, and I can complete the remaining folders. What do you say? Also, thanks for great work on it till now!! |
grvsachdeva
added
the
Translation System
|
@gauravano Sorry for the late response. I was caught up with my mid term exams. I can complete this by tomorrow(11th Feb) afternoon. |
akshaygupta533
changed the title
|
Oh, no issue Akshay! All the best for your exams and if you want I can
complete the remaining bits? Thanks!
…On Sun, Feb 10, 2019 at 6:15 PM Akshay Gupta ***@***.***> wrote:
@gauravano <https://github.com/gauravano> Sorry for the late response. I
was caught up with my mid term exams. I can complete this by tomorrow(11th
Feb) afternoon.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4751 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AT6S9sx0YSJ2lNwx8ts0Zw1n96KcLW_Tks5vMBRvgaJpZM4af9WQ>
.
|
|
I'll do it. No worries, thanks:) |
akshaygupta533
force-pushed
the
pr-4716
branch
from
7948e60
to
0a0c31c
Compare
|
@gauravano pls check |
|
@akshaygupta533 I will take a look and solve the merge conflict too. Thanks for completing it even in-between your exams. |
|
Hi @jywarren, the PR I opened at #4716 which intends to combine YML files is merged in this one only and @akshaygupta533 and I have put quotes over the en translation values. I have also put double quotes at some places where it wasn't present before just to maintain the uniform syntax of the combined file. Now, pushing this PR to |
|
@jywarren please review this PR and you can test the changes at unstable too. Thanks! |
|
Looks awesome everyone! Great work here. Thanks!!! 👍 👍 👍 |
|
Thanks @jywarren! And, thanks @akshaygupta533 for working on this one 🎉 ! |
|
@akshaygupta533 , thanks for nice work. We would love to have more help from you. If you are interested in solving more issues then check here - https://code.publiclab.org/#r=all for a new issue. In case, you are unable to find an issue, feel free to comment here. Thanks! |
|
@gauravano I would surely love to work on more issues. Meanwhile, if you find any issue suitable for me, please mention me. Thanks! 😄 |
…/controllers files (publiclab#4751) * English locales combined * controller locales removed * all en files deleted * chinese files combined manually * Translation: Put single/double quotes around values in locale files * error removal by enclosing . in quotes * corrections * corrections + double quotes changes
Fixes #4729 #4702
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test@publiclab/reviewersfor help, in a comment belowIf tests do fail, click on the red
Xto learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!