-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Ability to Update Video Resolution through getUserMedia #173
Conversation
Hello, would you be able to rebase this over the latest main branch following the merge of #172? Thank you! |
This looks really good on close review. Would it be possible to add another option to change the camera to the rear-facing camera for mobile devices? I see some usage in temasys/adapterjs here: I think that means the face: {
ideal: 'rear'
} so it defaults to rear camera, which is how the spectrometer would attach: This could easily be its own separate PR, but as this PR touches the same code and needs a rebase, perhaps it's an easy addition? Thank you!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would be the only change on top of the rebase! Thanks!
This adds the ability for user to update video resolution through getUserMedia constraints. Currently we hardcoded five resolution options (1080p, 720p, 480p, 360p, 240p). An error message would be shown if any error occurs. (e.g. overconstrained, not allowed etc.). A success message would be shown when resolution gets updated successfully.
724a1ee
to
6eefde4
Compare
Rebased it, let's see! |
This looks good, it didn't use the environment-facing mode in Android Chrome but maybe it'll do so on iOS... |
Decription
This update is based on a previous PR
This adds the ability for user to update video resolution through getUserMedia constraints. Currently we hardcoded five resolution options (1080p, 720p, 480p, 360p, 240p). An error message would be shown if any error occurs. (e.g. overconstrained, not allowed etc.). A success message would be shown when resolution gets updated successfully.
Make sure these boxes are checked before your pull request is ready to be reviewed and merged. Thanks!
Please be sure you've reviewed our contribution guidelines at https://publiclab.org/wiki/contributing-to-public-lab-software
Please alert developers on plots-dev@googlegroups.com when your request is ready or if you need assistance.
Thanks!