Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add replit.app and replit.dev #1679

Merged
merged 8 commits into from
Mar 1, 2024
Merged

Add replit.app and replit.dev #1679

merged 8 commits into from
Mar 1, 2024

Conversation

lincoln-replit
Copy link
Contributor

@lincoln-replit lincoln-replit commented Jan 5, 2023 •
edited
Loading

Public Suffix List (PSL) Pull Request (PR) Template

Each PSL PR needs to have a description, rationale, indication of DNS validation and syntax checking, as well as a number of acknowledgements from the submitter. This template must be included with each PR, and the submitting party MUST provide responses to all of the elements in order to be considered.

Checklist of required steps

  • Description of Organization

  • Robust Reason for PSL Inclusion

  • DNS verification via dig

  • Run Syntax Checker (make test)

  • Each domain listed in the PRIVATE section has and shall maintain at least two years remaining on registration, and we shall keep the _PSL txt record in place in the respective zone(s) in the affected section

Submitter affirms the following:

  • We are listing any third-party limits that we seek to work around in our rationale such as those between IOS 14.5+ and Facebook (see Issue #1245 as a well-documented example)
  • This request was not submitted with the objective of working around other third-party limits
  • The Guidelines were carefully read and understood, and this request conforms
  • The submission follows the guidelines on formatting and sorting

For Private section requests that are submitting entries for domains that match their organization website's primary domain, please understand that this can have impacts that may not match the desired outcome and take a long time to rollback, if at all.

To ensure that requested changes are entirely intentional, make sure that you read the affectation and propagation expectations, that you understand them, and confirm this understanding.

PR Rollbacks have lower priority, and the volunteers are unable to control when or if browsers or other parties using the PSL will refresh or update.

(Link: about propagation/expectations)

  • Yes, I understand. I could break my organization's website cookies etc. and the rollback timing, etc is acceptable. Proceed.

Description of Organization

Replit is an online programming environment that allows users to create and host their own websites and applications. I am an engineer at Replit.

In order to continue to fight spam and abuse on our platform, we are launching two new domains to host user websites. They will behave similarly to the repl.co domain where Replit users' websites are hosted now, but there will be stricter requirements around who can deploy to these domains.

Organization Website: https://replit.com/

Reason for PSL Inclusion

Replit users host their websites on replit.app, just like they do on repl.co. User websites should be isolated and cookies should be properly segregated. replit.dev is just like replit.app but is used for development environments rather than production.

We have more than two years left on registration for these domains. We intend to hold these domains forever.

Number of users this request is being made to serve: over 1 million

DNS Verification via dig

$ dig +short TXT _psl.replit.app
"https://github.com/publicsuffix/list/pull/1679"
$ dig +short TXT _psl.id.replit.app
"https://github.com/publicsuffix/list/pull/1679"
$ dig +short TXT _psl.replit.dev
"https://github.com/publicsuffix/list/pull/1679"
$ dig +short TXT _psl.archer.replit.dev
"https://github.com/publicsuffix/list/pull/1679"
$ dig +short TXT _psl.bones.replit.dev
"https://github.com/publicsuffix/list/pull/1679"
$ dig +short TXT _psl.canary.replit.dev
"https://github.com/publicsuffix/list/pull/1679"
$ dig +short TXT _psl.global.replit.dev
"https://github.com/publicsuffix/list/pull/1679"
$ dig +short TXT _psl.hacker.replit.dev
"https://github.com/publicsuffix/list/pull/1679"
$ dig +short TXT _psl.id.replit.dev
"https://github.com/publicsuffix/list/pull/1679"
$ dig +short TXT _psl.janeway.replit.dev
"https://github.com/publicsuffix/list/pull/1679"
$ dig +short TXT _psl.kim.replit.dev
"https://github.com/publicsuffix/list/pull/1679"
$ dig +short TXT _psl.kira.replit.dev
"https://github.com/publicsuffix/list/pull/1679"
$ dig +short TXT _psl.kirk.replit.dev
"https://github.com/publicsuffix/list/pull/1679"
$ dig +short TXT _psl.odo.replit.dev
"https://github.com/publicsuffix/list/pull/1679"
$ dig +short TXT _psl.paris.replit.dev
"https://github.com/publicsuffix/list/pull/1679"
$ dig +short TXT _psl.picard.replit.dev
"https://github.com/publicsuffix/list/pull/1679"
$ dig +short TXT _psl.pike.replit.dev
"https://github.com/publicsuffix/list/pull/1679"
$ dig +short TXT _psl.prerelease.replit.dev
"https://github.com/publicsuffix/list/pull/1679"
$ dig +short TXT _psl.reed.replit.dev
"https://github.com/publicsuffix/list/pull/1679"
$ dig +short TXT _psl.riker.replit.dev
"https://github.com/publicsuffix/list/pull/1679"
$ dig +short TXT _psl.sisko.replit.dev
"https://github.com/publicsuffix/list/pull/1679"
$ dig +short TXT _psl.spock.replit.dev
"https://github.com/publicsuffix/list/pull/1679"
$ dig +short TXT _psl.staging.replit.dev
"https://github.com/publicsuffix/list/pull/1679"
$ dig +short TXT _psl.sulu.replit.dev
"https://github.com/publicsuffix/list/pull/1679"
$ dig +short TXT _psl.tarpit.replit.dev
"https://github.com/publicsuffix/list/pull/1679"
$ dig +short TXT _psl.teams.replit.dev
"https://github.com/publicsuffix/list/pull/1679"
$ dig +short TXT _psl.tucker.replit.dev
"https://github.com/publicsuffix/list/pull/1679"
$ dig +short TXT _psl.wesley.replit.dev
"https://github.com/publicsuffix/list/pull/1679"
$ dig +short TXT _psl.worf.replit.dev
"https://github.com/publicsuffix/list/pull/1679"

Results of Syntax Checker (make test)

make test passed.

@lincoln-replit lincoln-replit marked this pull request as ready for review January 5, 2023 17:07
@dnsguru
Copy link
Member

dnsguru commented Jan 9, 2023

Also see: #1239 #1568

@lincoln-replit lincoln-replit changed the title Add replit.app Add replit.app and replit.dev Jan 16, 2023
@lincoln-replit
Copy link
Contributor Author

Is there anything else we need to do to get this added to the list? Happy to provide any other documentation that would help to verify this domain.

@dnsguru dnsguru self-assigned this Sep 16, 2023
@dnsguru dnsguru added the ✔️DNS _psl Validated RFC 8553 Entries were present, matching PR# label Sep 18, 2023
dnsguru
dnsguru requested changes Sep 18, 2023
View reviewed changes
Copy link
Member

@dnsguru dnsguru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inches from goal, I finally had some volunteer cycles to put in to the project and was working to advance this pull request when I noticed that the sort order doesnt match the guidelines...

Please sort these by TLD,SLD,3LD ascending and @ me when you do it (ie the .app ones up above the .co, the .dev after the .co and .run at the end) The third levels are in the right order within their sld.tld (id.foo.bar after foo.bar), but the TLDs just need a quick move.

@dnsguru dnsguru added the ❌FAIL - FIX SORTING ⏬ https://github.com/publicsuffix/list/wiki/Guidelines#sort-your-submission-correctly-important label Sep 18, 2023
@lincoln-replit
Copy link
Contributor Author

Thanks @dnsguru -- I believe I've got the sorting correct now.

@lincoln-replit
Copy link
Contributor Author

FYI, I added a couple more subdomains to the list here. All should be configured and alphabetized as expected and I've updated the PR description as well.

@mozfreddyb mozfreddyb removed ❌FAIL - FIX SORTING ⏬ https://github.com/publicsuffix/list/wiki/Guidelines#sort-your-submission-correctly-important ✔️DNS _psl Validated RFC 8553 Entries were present, matching PR# labels Nov 30, 2023
@mozfreddyb
Copy link
Contributor

Thanks. Needs re-checking then.

@lincoln-replit
Copy link
Contributor Author

To clarify @mozfreddyb, are you saying that any additional work needs to be done on our part?

simon-friedberger
simon-friedberger requested changes Feb 5, 2024
View reviewed changes
Copy link
Contributor

@simon-friedberger simon-friedberger left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Expiration
    • replit.app expires 2033-04-16
    • replit.dev expires 2029-01-26
  • DNS _psl entries
  • Tests pass
  • Sorting
  • Reasoning/Organization description

@simon-friedberger simon-friedberger added ❌FAIL - DOMAIN NOT 2Y+ *ALL* names in PRIVATE section MUST hold terms of 2 years or more registration from PR date #1109 ✔️DNS _psl Validated RFC 8553 Entries were present, matching PR# ✔️Sorting Validated https://github.com/publicsuffix/list/wiki/Guidelines#sort-your-submission-correctly-important r=simon-friedberger Marked as approved and ready to merge by @simon-friedberger labels Feb 5, 2024
@lincoln-replit
Copy link
Contributor Author

Sorry about that, I thought the registration was 5+ yrs out. That's fixed now.

@simon-friedberger simon-friedberger removed the ❌FAIL - DOMAIN NOT 2Y+ *ALL* names in PRIVATE section MUST hold terms of 2 years or more registration from PR date #1109 label Feb 7, 2024
@simon-friedberger
Copy link
Contributor 

$ dig +short TXT _psl.replit.dev
"https://github.com/publicsuffix/list/pull/1679"

Did this disappear? Please keep the >2y validity and the DNS entries for as long as you want to keep the domains on the PSL!

@lincoln-replit
Copy link
Contributor Author

@simon-friedberger Just added it back in! We'll make sure to keep it on there.

@dnsguru dnsguru merged commit 8826ef6 into publicsuffix:master Mar 1, 2024
1 check passed
sjledoux pushed a commit to sjledoux/PSL-Check-Automation that referenced this pull request Apr 1, 2024
@lincoln-replit @sjledoux
Add replit.app and replit.dev (publicsuffix#1679)
fbd803e 
* Add replit.app to PSL

* add replit.dev too

* fix sorting

* add some more subdomains

* add a couple more domains

* change email address to non-personal
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simon-friedberger simon-friedberger simon-friedberger approved these changes

@dnsguru dnsguru Awaiting requested review from dnsguru

Assignees

@dnsguru dnsguru

Labels
✔️DNS _psl Validated RFC 8553 Entries were present, matching PR# r=simon-friedberger Marked as approved and ready to merge by @simon-friedberger ✔️Sorting Validated https://github.com/publicsuffix/list/wiki/Guidelines#sort-your-submission-correctly-important
Projects
List Add/Mod/Del
Status: Done or Won't
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lincoln-replit @dnsguru @mozfreddyb @simon-friedberger