Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding quipelements.com domain for Quip. #427

Merged
merged 2 commits into from
Apr 11, 2017
Merged

Conversation

plinehan
Copy link
Contributor

@plinehan plinehan commented Mar 29, 2017

This domain is used to host customer applications on individual subdomains. We would like to prevent these applications from storing cookies both within their own subdomain and on the root domain.

@plinehan
Copy link
Contributor Author

Please find that our DNS records have been updated:
dig TXT _psl.quipelements.com

This domain is used to host customer applications on individual subdomains. We would like to prevent these applications from storing cookies both within their own subdomain and on the root domain.
@weppos
Copy link
Member

weppos commented Mar 31, 2017

@plinehan can you provide some examples of domains? According to what you said, you probably misinterpreted the rule.

You should probably have quipelements.com, not *.quipelements.com

@weppos weppos added the waiting-followup Blocked for need of follow-up label Mar 31, 2017
@plinehan
Copy link
Contributor Author

Absolutely, thanks for the followup!

For content served from this domain:

element-a.quipelements.com

We would like to prevent cookies being set on both of these domains:

quipelements.com
element-a.quipelements.com

This follows for any like-named domains, e.g. element-b.quipelements.com.

No content will ever be served directly from quipelements.com or from deeper subdomains, e.g. foo.element-a.quipelements.com. Our SSL cert doesn't even apply to these domain names.

Based on my original reading of the spec I thought I wanted two rules:

quipelements.com
*.quipelements.com

but make test reported that as a redundant error.

Thanks for any help you can offer!

@plinehan
Copy link
Contributor Author

plinehan commented Apr 5, 2017

Hi @weppos if what I'm asking for is impossible, I'd much rather block cookies on the root domain, quipelements.com, than on the subdomains, e.g. element-a.quipelements.com.

@sleevi
Copy link
Contributor

sleevi commented Apr 7, 2017

Can you explain why you want to block cookies for element-a.quipelements.com given that you will never be serving content from foo.element-a.quipelements.com ? As @weppos mentioned, typically the *.example syntax is used to indicate that there's a foo.bar.example domain and baz.bar.example domain, and both foo and baz are independent.

Blocking cookies for quipelements.com from being set by element-a and element-b is possible by just removing the wildcard.

@plinehan
Copy link
Contributor Author

Yes, our use-case is rather unusual.

We want to block element-a.quipelements.com from setting cookies on quipelements.com for the obvious reasons... element-a and element-b are independent and unrelated.

However, we also don't want content served from element-a.quipelements.com to be able to set cookies for its own domain, element-a.quipelements.com. Content from this location is only served from within a very strictly sandboxed iframe, and, for security reasons, we don't even want cookies from one instance of this iframe leaking into other instances of this iframe. We already pragmatically block the JavaScript APIs for setting cookies within these iframes, but we'd like the additional security layer of having the browser enforce it for us, as well.

If I have to make the choice between blocking cookies on the subdomains or just on quipelements.com, I'd gladly choose the latter, but ideally I could do both. Thanks again for your help.

@sleevi
Copy link
Contributor

sleevi commented Apr 11, 2017

Thanks for clarifying. Using the wildcard approach is the best compatibility with existing user agents. There's been a long discussion about whether a PSL entry of *.foo.bar.baz implies that foo.bar.baz is or is not a public suffix. Implementations vary, hence the current rules preventing both. In the future, it may be necessary to add quipelements.com as well to the list.

@gerv @weppos I couldn't find the discussion on GitHub (the closest is #145 ). The previous discussion was captured in https://wiki.mozilla.org/Public_Suffix_List/platform.sh_Problem

@sleevi sleevi added r=gerv and removed waiting-followup Blocked for need of follow-up labels Apr 11, 2017
@sleevi sleevi merged commit 689b85f into publicsuffix:master Apr 11, 2017
@sleevi sleevi added h=sleevi (historical) Marked as approved and ready to merge by @sleevi and removed r=gerv labels Apr 11, 2017
@plinehan
Copy link
Contributor Author

Thank you so much for all your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
h=sleevi (historical) Marked as approved and ready to merge by @sleevi
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants