Added a test for dns records #603
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnsguru
added
the
❌FAIL - REBASE NEEDED
|
@foosinn thank you for having taken the time to write this ; Stuff got stale due to volunteer cycles and fewer dev than clerical reviewer volunteers. At this point the .travis.yml has a code base conflict that needs a resolution and I'd like to close this for now until there are some cycles available for you to review this and then I am not certain with whom from PSL side we could look at the automation once that might happen. Reference this PR when that occurs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As asked on the mailing list a did a test do verify the dns lookups. To prevent any dns caching issues the test tries to request the responsible nameserver directly.
Most of the time users should be able to correctly "guess" their pull request number before doing a pull-request. If that did not work they can simply run the test again after fixing the dns entries.
To manually run a test use
make checkdns. You will be asked for the number of your pull request.It also creates a set of tests to test the script itself. See
tests/check_dns.sh_tests/run_tests.sh