Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shopware.store domain #958

Merged
merged 1 commit into from
Apr 24, 2020
Merged

Add shopware.store domain #958

merged 1 commit into from
Apr 24, 2020

Conversation

jenskueper
Copy link
Contributor

@jenskueper jenskueper commented Feb 5, 2020

  • Description of Organization
  • Reason for PSL Inclusion
  • DNS verification via dig
  • Run Syntax Checker (make test)

Description of Organization

Organization Website: https://shopware.store
I am an engineer at shopware working on our SaaS hosting for e-commerce shops which are based on Shopware 6 (https://github.com/shopware/platform).

Reason for PSL Inclusion

Cookie security between subdomains since the subdomains will be managed and run by different organizations with the ability to set cookies.

DNS Verification via dig

dig +short TXT _psl.shopware.store
"https://github.com/publicsuffix/list/pull/958"

make test

All passed

@jenskueper jenskueper marked this pull request as ready for review February 5, 2020 13:37
@jenskueper jenskueper requested a review from weppos February 5, 2020 14:23
@weppos weppos removed their request for review February 5, 2020 14:42
@sleevi sleevi added the ❔❔ question Open question, please look / answer / respond label Feb 5, 2020
@sleevi
Copy link
Contributor

sleevi commented Feb 5, 2020

Could you indicate why you're requesting shopwaredemo.store?

That is, per the Guidelines, can you:

  • When submitting private domains, add a brief description of why you want the suffix(es) to be added to the list
  • When submitting private domains, provide expected input/output to help us validate the correctness of the request
    ...
  • Provide extra information useful for the PSL team to handle the pull request

@jenskueper
Copy link
Contributor Author

Hello sleevi,

thank you for the fast response! We currently have two domains:

  • shopwaredemo.store: Anybody can request a demo for our e-commerce shop system (Shopware 6). They get their own subdomain and access to a their shop which they can modify to try out our service but they can't generate revenue with it
  • shopware.store is for real production shops. They will also receive a subdomain and full access to their shop

If we can only add one domain to the list, I would remove shopwaredemo.store since the risk/chance of cookie manipulation is lower compared to shopware.store where production shop with real transactions are hosted.

Best regards
Jens

@jenskueper
Copy link
Contributor Author

Hello @sleevi,

I just wanted to ask if the answer above is sufficient or if I can assist in any way to move this issue forward.

Best regards
Jens

@jenskueper jenskueper requested a review from sleevi February 20, 2020 10:22
@jenskueper jenskueper closed this Mar 5, 2020
@jenskueper jenskueper reopened this Mar 5, 2020
@jenskueper
Copy link
Contributor Author

Hello @sleevi,

I removed shopwaredemo.store so only our main/production domain is now included.

Best regards
Jens

@jenskueper jenskueper changed the title Add shopware.store and shopwaredemo.store domains Add shopware.store domain Mar 30, 2020
@dnsguru dnsguru self-assigned this Apr 10, 2020
@dnsguru dnsguru self-requested a review April 10, 2020 05:14
@dnsguru
Copy link
Member

dnsguru commented Apr 10, 2020

@jenskueper Thank you for reducing the request to a single domain and providing additional rationale

  • Rationale ok
  • tests pass
  • DNS Validation Verified
>nslookup -type=txt _psl.shopware.store
Server:  one.one.one.one
Address:  1.1.1.1

Non-authoritative answer:
_psl.shopware.store     text =        "https://github.com/publicsuffix/list/pull/958"

@dnsguru dnsguru added the h=sleevi (historical) Marked as approved and ready to merge by @sleevi label Apr 10, 2020
@dnsguru
Copy link
Member

dnsguru commented Apr 10, 2020

@sleevi please confirm the rationale was addressed - I have reviewed it and the DNS validation all looks accurate. Merge if ok or add q's

@jenskueper
Copy link
Contributor Author

Thank you @dnsguru for the positive response. If I see it correctly @sleevi has approved afterward. It would be awesome if the PR could be merged in the near future.

@dnsguru dnsguru merged commit c5e8660 into publicsuffix:master Apr 24, 2020
@dnsguru dnsguru removed ❔❔ question Open question, please look / answer / respond h=sleevi (historical) Marked as approved and ready to merge by @sleevi labels Apr 24, 2020
@jenskueper jenskueper deleted the patch-1 branch April 24, 2020 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants