Adding endpoint support to S3 provider #30
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. I'll take a look at this today or tomorrow. |
Merging initial release
Merge pull request #1 from rehmatworks/development
Development
…into development
Development
Development
Fixing Facade name
|
I can't pull this request as you have renamed all of the namespaces, including the composer.json package name. This would be a breaking change. |
Merged
|
I've make the required edits in #31, if you'd like to use that instead? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently tried this package to use DigitalOcean spaces as my assets CDN. By just adding endpoint support to the S3 provider, I got it working flawlessly. I hope this feature helps several others as well.