Change message type to type. Type do not have fallback #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kleewho
force-pushed
the
CLEN-1159_finalize_message_type
branch
from
e27842d to
a25f2ba
Compare
Xavrax
approved these changes
Mar 24, 2023
| } else { | ||
| histItem.MessageType = "" | ||
| o.pubnub.Config.Log.Printf("histResponse message_type nil") |
There was a problem hiding this comment.
Apparently this is how this code worked before. I'm not actually changing that. This is how it looks like straight on master
| @@ -725,7 +719,7 @@ func processSubscribePayload(m *SubscriptionManager, payload subscribeMessage) { | |||
| } | |||
| } | |||
|
|
|||
| func createPNFilesEvent(filePayload interface{}, m *SubscriptionManager, actualCh, subscribedCh, channel, subscriptionMatch, issuingClientID string, userMetadata interface{}, timetoken int64, messageType MessageType, spaceId SpaceId) *PNFilesEvent { | |||
| func createPNFilesEvent(filePayload interface{}, m *SubscriptionManager, actualCh, subscribedCh, channel, subscriptionMatch, issuingClientID string, userMetadata interface{}, timetoken int64, typ string, spaceId SpaceId) *PNFilesEvent { | |||
There was a problem hiding this comment.
Is that a typo?
Suggested change
| func createPNFilesEvent(filePayload interface{}, m *SubscriptionManager, actualCh, subscribedCh, channel, subscriptionMatch, issuingClientID string, userMetadata interface{}, timetoken int64, typ string, spaceId SpaceId) *PNFilesEvent { | |
| func createPNFilesEvent(filePayload interface{}, m *SubscriptionManager, actualCh, subscribedCh, channel, subscriptionMatch, issuingClientID string, userMetadata interface{}, timetoken int64, type string, spaceId SpaceId) *PNFilesEvent { |
There was a problem hiding this comment.
Nope. I had plenty of options to choose from, but type is not one of them. It's a reserved keyword so we need to be creative with words :)
| @@ -757,7 +751,7 @@ func createPNFilesEvent(filePayload interface{}, m *SubscriptionManager, actualC | |||
| Publisher: issuingClientID, | |||
| UserMetadata: userMetadata, | |||
| SpaceId: spaceId, | |||
| MessageType: messageType, | |||
| Type: typ, | |||
There was a problem hiding this comment.
same here?
Suggested change
| Type: typ, | |
| Type: type, |
There was a problem hiding this comment.
As stated in previous comment. Not typo. Keyword. That's just life :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.