Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add custom message type #167

Merged
merged 8 commits into from
Dec 10, 2024
Merged

add custom message type #167

merged 8 commits into from
Dec 10, 2024

Conversation

Xavrax
Copy link
Contributor

@Xavrax Xavrax commented Dec 10, 2024

feat: add CustomMessageType to messages and files

add CustomMessageType to messages and files

@Xavrax Xavrax added priority: high This PR should be reviewed ASAP. type: feature This PR contains new feature. labels Dec 10, 2024
@Xavrax
Copy link
Contributor Author

Xavrax commented Dec 10, 2024

I will fix paddings within next PRs with reformating the whole repo.

seba-aln
seba-aln approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@seba-aln seba-aln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to add a ticket for reformat and linting in validation

seba-aln
seba-aln approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@seba-aln seba-aln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍏

@Xavrax
Copy link
Contributor Author

Xavrax commented Dec 10, 2024

@pubnub-release-bot release

@Xavrax Xavrax merged commit 0aace5c into master Dec 10, 2024
8 checks passed
@Xavrax Xavrax deleted the feat/custom_message_type branch December 10, 2024 14:51
@pubnub-release-bot
Copy link
Contributor

🚀 Release successfully completed 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seba-aln seba-aln seba-aln approved these changes

@marcin-cebo marcin-cebo Awaiting requested review from marcin-cebo marcin-cebo is a code owner

Assignees
No one assigned
Labels
priority: high This PR should be reviewed ASAP. type: feature This PR contains new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Xavrax @pubnub-release-bot @seba-aln @parfeon