Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(message-type): rename messageType to type #447

Merged
merged 2 commits into from
Mar 30, 2023

Conversation

parfeon
Copy link
Contributor

@parfeon parfeon commented Mar 28, 2023

refactor(message-type): rename messageType to type

Rename field in responses and request configuration from messageType to type and update history endpoint include flags.

Rename field in responses and request configuration from `messageType` to `type` and update
history endpoint include flags.
@parfeon parfeon added status: done This issue is considered resolved. priority: medium This PR should be reviewed after all high priority PRs. type: refactor This PR contains refactored existing features. labels Mar 28, 2023
@parfeon parfeon requested a review from jguz-pubnub as a code owner March 28, 2023 08:05
@parfeon parfeon self-assigned this Mar 28, 2023
Remove class forwarding for `PNMessageType` which has been removed.
@parfeon parfeon merged commit 2daaaaa into feat/add-message-type Mar 30, 2023
@parfeon parfeon deleted the refactor/change-type-field-names branch March 30, 2023 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: medium This PR should be reviewed after all high priority PRs. status: done This issue is considered resolved. type: refactor This PR contains refactored existing features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants