Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto Fade Settings ( <1sec or 0.5) and mouse wheel release for scrolling doc pages while drawing - feature please #59

Closed
lucacuccu3x8 opened this issue Feb 26, 2021 · 40 comments

Comments

@lucacuccu3x8
Copy link

Hi pubpub-zz
Thank you again for your amazing work.

  • Is there any chances please, that you could give the Auto-Fade a more granular setting (for faster fades) in the order of <1sec please?(or better decimal numbers like 0.5 sec)
    for e.g.
    When doing live presentations and reading through documents, sometimes a fast reader would need the highlights to fade sooner, please?

  • Auto fade user-settings amended from the ppInk "Options", seems to roll back to default 5sec each time I re-launch the application. Only If I modify the configuration file, the custom-settings are remembered after re-launch.

  • Also, the mouse wheel seems to be tightened with the width of the drawings..
    is there any chances please to add a setting for releasing the mouse wheel from the grasp of ppInk,
    so that it behaves as it intended, for scrolling e.g. web pages or documents, please?
    (so that it avoids the need to Alt+F4 ppInk each time someone needs to get the mouse wheel back for scrolling please?)
    Again, the latter could be useful when doing live presentations and reading through long documents in a class.

Thank you so much!

@pubpub-zz
Copy link
Owner

pubpub-zz commented Feb 26, 2021

  • Is there any chances please, that you could give the Auto-Fade a more granular setting (for faster fades) in the order of <1sec please?(or better decimal numbers like 0.5 sec)

You can set decimal figures. I've tried .1s successfully. the only current "bug" is that the types time applies to pens ticked after. currently,if a pen is already ticked, You have to untick/ tick it in order to be taken into account.

for e.g.
When doing live presentations and reading through documents, sometimes a fast reader would need the highlights to fade sooner, please?

  • Auto fade user-settings amended from the ppInk "Options", seems to roll back to default 5sec each time I re-launch the application. Only If I modify the configuration file, the custom-settings are remembered after re-launch.

I've forgot to add the entry in config.ini : add Fading_Time=.1 in the file (where you want) and it will save.

  • Also, the mouse wheel seems to be tightened with the width of the drawings..
    is there any chances please to add a setting for releasing the mouse wheel from the grasp of ppInk,
    so that it behaves as it intended, for scrolling e.g. web pages or documents, please?

Currently mouse events are globally captured by the application or ppInk is click through ( when in pointer mode) I do not know if it is possible to just let some events to get through. will check

(so that it avoids the need to Alt+F4 ppInk each time someone needs to get the mouse wheel back for scrolling please?)
Again, the latter could be useful when doing live presentations and reading through long documents in a class.

Instead of alt+F4, you may prefer Esc(which is doing the same) or alt+tab(which will start/end the pointer mode)

@pubpub-zz
Copy link
Owner

I confirm that there is no easy solution to transfer only some events to underlying window but I've though about your problem to get scrolling : my proposal is to put ppInk in "window" mode : in this mode not the whole surface will be covered with the window and you will be able to scroll moving the mouse out of ppink window
ppInkWindow.zip

To start window mode, you have to long click or right click on snap tool and then mark the new window. Note that this a alpha version

@lucacuccu3x8
Copy link
Author

Hi pubpub.
Hey, ain't got any issue/problem with your app. It is great already as it is.
I only thought to make a suggestion.
When I need the scrolling of the wheel, I use hotkeys to get out from pink with Esc - it gets messy, but it only takes practice.
And, btw the faster fading is great. That's all that we needed!
Thank you for your time.

@pubpub-zz
Copy link
Owner

I've finalized this version.
ppInkWindow2.zip

For your usage, I would recommend this following use approach:
start ppInk
open options dialog
desactivate engage on alt+tab and allow moving toolbar
image
display your browser / text / application on foreground
start inking
right click or long click on snapshot
draw the inking surface that will cover the required text but leaving access to the scrollbars or any are that you may need direct access to : ppInk will reduce to a window over the designated area:
image
The area directly accessible to mouse clicks and wheels

@lucacuccu3x8
Copy link
Author

Great thanks.

I've noticed that the settings for the AutoFading are not persisting after either Closing the application(not minimizing) and relaunch, or after reboot of the system.
all other settings seems to persist, yet the auto fading goes back to 5 sec default.
my settings are autofading @ 0.7sec
Do you know a way around this please?
thank you!

@pubpub-zz
Copy link
Owner

Oops,

Got it : pens.ini was loaded before config.ini, therefore the default fading was applied on pen before loading the value from config.ini. It is now fixed :
ppInk2.zip

@lucacuccu3x8
Copy link
Author

lucacuccu3x8 commented Mar 3, 2021

Hi pubpub-zz
The auto-fading setting persists now, thank you.
One thing though - I've noticed that now the "switches between mouse and pointer and drawing", doesn't work properly now.
When recalling the mouse pointer, The drawing stays while the bar minimizes - now the only way to get the mouse back is either

  • to select it manually from the toolbar
    or

  • ESC the ppink.


Also,
If I may suggest please:
Perhaps a multi-functional use of the mouse wheel, please?
other than scale up and down the width of the pen,
is it possible to add an optional setting to select the Pen (pen 1, pen 2, pen3, ..) with the wheel of the mouse instead, please?

  • it will avoid going up and down on the screen every time you need to select a different pen. (I know hotkeys are an option, but messy alright!) - I think the mouse wheel is a very convenient and fast selector.
    What do you think?

@pubpub-zz
Copy link
Owner

have a look to this issue and its fix : #49

@lucacuccu3x8
Copy link
Author

sorry pupu.
I've edited the comment before looking at your reply already.
Please check the first part of my early meassge.
thank you!

@pubpub-zz
Copy link
Owner

One thing though - I've noticed that now the "switches between mouse and pointer and drawing", doesn't work properly now.
When recalling the mouse pointer, The drawing stays while the bar minimizes - now the only way to get the mouse back is either

can you pls describe the exact actions you are doing

@lucacuccu3x8
Copy link
Author

I'm using the GlobalHotkey(starts drawing, switches between the mouse pointer and drawing) -
it doesn't give you back the mouse now, it only minimizes the ppink toolbar yet still drawing.
While before, it uses to minimize the toolbar and giving you back the mouse?

regarding the fix #49
sorry for the ignorance but what key is a D1?
do I need that pink.zip you posted in there, for it to work? or is the feature included in your latest zips?
thanks

@lucacuccu3x8
Copy link
Author

sorry for the caps

@pubpub-zz
Copy link
Owner

pubpub-zz commented Mar 3, 2021

regarding the fix #49
sorry for the ignorance but what key is a D1?
do I need that pink.zip you posted in there, for it to work? or is the feature included in your latest zips?
thanks

D1 used to be the name for numeric key 1 on top line. It can be any key just , put the same hotkey for both pen 0 and pen 1
This is included in the latest build 1.5beta

@lucacuccu3x8
Copy link
Author

Thanks pubpub-zz
the mouse wheel doesn't work with me - nevermind
Have you noticed the Global Key issue please?

@pubpub-zz
Copy link
Owner

I'm using the GlobalHotkey(starts drawing, switches between the mouse pointer and drawing) -
it doesn't give you back the mouse now, it only minimizes the ppink toolbar yet still drawing.
While before, it uses to minimize the toolbar and giving you back the mouse?

I've detected some bugs in version 1.4 that were fixed and released in 1.5. It is also in the evaluation version I've sent earlier on this post. Can you check with both ?

Thx

@lucacuccu3x8
Copy link
Author

The 1.5.0.0 doesn't have it. ( but with the autofade settings no persisting)
The zip you sent me here with the autofade persisting fix, has this bug of the global key now.

@pubpub-zz
Copy link
Owner

the mouse wheel doesn't work with me - nevermind

What do you mean not working ?

The 1.5.0.0 doesn't have it. ( but with the autofade settings no persisting)
The zip you sent me here with the autofade persisting fix, has this bug of the global key now.

OK will review the code

@pubpub-zz
Copy link
Owner

Can you send me your ini files from the version which has the issue pls

@lucacuccu3x8
Copy link
Author

Annotation 2021-03-03 152217

@lucacuccu3x8
Copy link
Author

that's the version where a trojan is flagged and where the Global Key doesn't work as before
Annotation 2021-03-03 152341

@pubpub-zz
Copy link
Owner

about detection, I've reported the issue to microsoft and it is confirmed to be a false detection
image

@pubpub-zz
Copy link
Owner

pubpub-zz commented Mar 3, 2021

about the hotkey problem, I can not reproduce the problem. 😞
here is a video where I'm using carnac( https://github.com/Code52/carnac/releases/tag/2.3.13 ) to display my keyboard actions:

CAPT_030321_230342_1.mp4

(I've used the FFMPEG option to manage the recording, and I've just seen that it hides the close button - oops to be fixed)

I've tried the shortcut and also with the mouse (click on pointer button and undock)

Can you confirm you have the same behavior, else can you provide your ini files
also can you try this version:
ppInk28.zip
thanks

@lucacuccu3x8
Copy link
Author

Hi ppInk -
I got so many version of ppInk now, that I'm overwhelmed and confused -
anyway, your version sent here earlier (ppInk28.zip) seems to respond well.
But... (sorry!)
The mouse wheel pen-selection setting (same value for each pen) seems to not respond to me.
Here's my whole zip copy(with all my settings) back to you
ppInk myini files.zip

@lucacuccu3x8
Copy link
Author

Regarding the mouse wheel settings for scrolling up and down the pen
the hotkey works(in my case D1)
but how to use the Wheel of the mouse for it? (not the Mouse3 button, but the actual wheel up&down)
thanks

@pubpub-zz
Copy link
Owner

Regarding the mouse wheel settings for scrolling up and down the pen
the hotkey works(in my case D1)
but how to use the Wheel of the mouse for it? (not the Mouse3 button, but the actual wheel up&down)
thanks

My answer/proposal was not to say that you can use the mouse wheel to rotate between pens but to use one key to rotate through.

@lucacuccu3x8
Copy link
Author

Regarding the mouse wheel settings for scrolling up and down the pen
the hotkey works(in my case D1)
but how to use the Wheel of the mouse for it? (not the Mouse3 button, but the actual wheel up&down)
thanks

My answer/proposal was not to say that you can use the mouse wheel to rotate between pens but to use one key to rotate through.

And I'm thankful for that as it works great.
I was only wondering if a feature for the mouse wheel could be implemented please?
Anyway, thanks for your amazing work and great support

@pubpub-zz
Copy link
Owner

This is a version with shift+mouse wheel to rotate pen:
ppInk5a.zip

I've fixed also the issue with the cursor not being refreshed until you move

By the way any progress on the tests I've assked you for hotkey issue ?

@lucacuccu3x8
Copy link
Author

lucacuccu3x8 commented Mar 7, 2021

Hi pp.
Although some hotkeys like the (clear, redo) are not immediately executed after pressing whatever key assigned(seems to be a delay), maybe it's only me. but Yes, the previous issue of the hotkey seems to be gone in the zip you posted here.

  • regarding the pen selection with the mouse wheel:

Is it possible to have this feature without the use of shift+ , in exchange for the Width increase/decrease of the pen? please?
or intruding a setting in the "Options" that will dictate the use of the mouse wheel in such a way please?

thanks

@lucacuccu3x8
Copy link
Author

Hi pp.
actually, my issue with the hotkey is back
please find here my zip with all my configurations:
ppInk-5a.zip
I'm using ctrl+alt+b to minimize ppink and get the mouse back to my control -

ppink.mp4

@lucacuccu3x8
Copy link
Author

as you can see in the clip, the hotkey minimizes ppInk but doesn't release the mouse, it still draws.

@pubpub-zz
Copy link
Owner

can you send your ini files pls

@lucacuccu3x8
Copy link
Author

ppInk-5a.zip

@pubpub-zz
Copy link
Owner

a) Globalhotkey issue:
I think I've found adn fix the problem
b) Pen rotating :
As an alternative to pressing shift, you can use CapsLock : if toggled on, you will rotate through pen (too many will be a mess for me)
ppInk8.zip

Also includes fixes for #60,#62,#63

@lucacuccu3x8
Copy link
Author

Thank you pubpub

Please allow me a couple of days to test it during live sessions, to check for persistence.
until then, thank you for your great work and patience

@pubpub-zz
Copy link
Owner

take your time
for your information I've issued a new interim version in
#63 (comment)

pubpub-zz added a commit that referenced this issue Mar 11, 2021
see #59
forgotten fading_time in config.ini
fading time not modifying already existing tagged pen
pubpub-zz added a commit that referenced this issue Mar 11, 2021
Add Window mode to allow access to windows around,+/- below 
Selection Activated by LongClick on Snap Button
answer to usecase described in #59
pubpub-zz added a commit that referenced this issue Mar 11, 2021
pubpub-zz added a commit that referenced this issue Mar 11, 2021
problem raised during testing in #59
pubpub-zz added a commit that referenced this issue Mar 11, 2021
Regression induced by code refactoring
cf issue #59
also prevent hotkey to be disabled when opening options (now only when entering/leaving global_hotkey)
pubpub-zz added a commit that referenced this issue Mar 11, 2021
rotate between pens with shift pressed of with caps lock toggled on
issue #59
@lucacuccu3x8
Copy link
Author

take your time
for your information I've issued a new interim version in
#63 (comment)

Thank you pubpub.
unfortunately CAPsLock on isn't convenient, as I need to type commands in terminals while doing live presentations. CAP on is a bother and it makes the whole thing confusing. Sorry, might be only me and my issue only, so please don't take it on a wrong way.
I though about the NUM lock, yet not convenient for the same reason thatI'm typing and switching off and on ppInk very often during my live sessions.
Please, Is there any chances to have the PenRotating function as something you could turn on-off for good,
in the "Options - ppInk", instead of the width(that I never happen to use), for e.g. here: (or whatever you think fit)

Screenshot 2021-03-13 152231

@pubpub-zz
Copy link
Owner

Hi @lucacuccu3x8,
I'm sorry that My proposal which was easy to code does not fit your need. Making the mousewheel to be so customizable is something which will require much more work : the mouse wheel changing the size is something I do not want to loose, therefore coding alternatives will be extra job. I will open a new issue with your request looking for other users opinion

@lucacuccu3x8
Copy link
Author

Hi pubpub,
I meant to implement an option to move/change how we control "changing size", not to loose it entirely.
but no problem at all. I can live with that.
thank you

@pubpub-zz
Copy link
Owner

@lucacuccu3x8
The latest exchange were no more about the original point which is now to be closed for me. do you agree ?

@lucacuccu3x8
Copy link
Author

yes. thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants