Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any plan to add android_kotlin_binary and android_kotlin_library rules? #5

Closed
fishy opened this issue Mar 11, 2017 · 8 comments
Closed

Comments

@fishy
Copy link
Contributor

fishy commented Mar 11, 2017

The current kotlin_library rule seems to be limited to pure kotlin library, I cannot find a way to use it to import Android libraries into kotlin (something like: https://kotlinlang.org/docs/tutorials/kotlin-android.html)

@pcj
Copy link
Contributor

pcj commented Mar 11, 2017

Hi @fishy, great idea. I'd certainly like to see this, but I may not have the spare cycles to do it right now.

@lswith
Copy link

lswith commented Jun 8, 2017

I'd love to see this feature as well.

@fishy
Copy link
Contributor Author

fishy commented Sep 8, 2017

Now that #32 is merged, I guess we can close this issue? :)

@pcj
Copy link
Contributor

pcj commented Sep 8, 2017

Agree.

Closed by #32.

@pcj pcj closed this as completed Sep 8, 2017
@edenman
Copy link

edenman commented Sep 9, 2017

Should I open a separate issue for the kotlin_android_binary improvement? Understood if it's not a priority right now, but I'd love to switch over to building my app with Bazel in CI :)

@fishy
Copy link
Contributor Author

fishy commented Sep 9, 2017

@edenman Is having two rules in your BUILD file, one android_binary and one kotlin_android_library not an option for your CI system? It should be trivial to add kotlin_android_binary with existing kotlin_android_library macro, I just don't feel it's very useful or needed.

@pcj
Copy link
Contributor

pcj commented Sep 9, 2017

@edenman
Copy link

edenman commented Sep 9, 2017

Oh nice, thanks for the pointer! Two rules is totally fine, I just didn't realize that would work. Now I'm just blocked on #15, can't wait to give it a try once that's resolved!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants