-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add kotlin_android_library
macro
#32
Conversation
Nice! |
@fishy can you clarify how I satisfy the support library dependencies for notifbot? Trying to compile your app:
|
You can change all "25.3.1" into "25.0.1" and that should work, too. It's not like I used any new feature in 25.3.1, I just tried to use the newest version available. It's not very obvious to me which packages in Android SDK provided the version 25.3.1 of the support libraries. Probably "Android SDK Platform 25, rev3"? Try update your Android SDK packages :) |
OK thanks, I'll try that. Seems like there could be a bazel android repository rule that interacts with |
I did some test, the package is "extras;android;m2repository" with version number "47.0.0". Since you have 25.0.1, I guess you have that package, but it's not the newest version. Try update that package in your Android SDK :) |
Tested, looks good. Thanks for this awesome contribution @fishy, this is a real leap forward in terms of making bazel enjoyable with android. |
The current
kotlin_library
macro has a problem with AAR libraries when generating the implicatedname.jar
file. This newkotlin_android_library
rule fixed it.The documentation is also updated.
https://github.com/fishy/notifbot/tree/kotlin is a working example.