fix: improvements in memory consumption #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think it should help to close #80
- preallocate config slices - not used interfaces in consumer - do not allocate new variables in loops
|
Hi! The module name has been changed, it doesn't matter, and if there are any problems, let me know, I'll return it back. The socks5 library used has been changed to a more up-to-date one. We also made a small optimization on the use of variables in loops. As a result, much less memory is consumed and requests are processed faster. |
juev
changed the title
|
Thanks for this huge PR. Really appreciate it. I'd review it when I have more bandwidth. Is this PR ready or are there more things to fix? |
|
I just corrected one of the errors that caused multiple http connections to be handled incorrectly. Now I think that everything is correct and can be checked. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it should help to close #80