Fix forbidden keys exception

.codeclimate.yml

@@ -14,6 +14,8 @@ engines:
     checks:
       UnusedFormalParameter:
         enabled: false
+      Design/TooManyPublicMethods:
+        enabled: false
 ratings:
   paths:
   - "**.php"

src/Jade/JadeSymfonyBundle/Command/AssetsPublishCommand.php

@@ -23,13 +23,12 @@ protected function cacheTemplates(Jade $pug)
         $directories = [];
         foreach ($pug->getOption('assetDirectory') as $assetDirectory) {
             $viewDirectory = $assetDirectory . DIRECTORY_SEPARATOR . '..' . DIRECTORY_SEPARATOR . 'views';
-            if (!is_dir($viewDirectory)) {
-                continue;
+            if (is_dir($viewDirectory)) {
+                $directories[] = $viewDirectory;
+                $data = $pug->cacheDirectory($viewDirectory);
+                $success += $data[0];
+                $errors += $data[1];
             }
-            $directories[] = $viewDirectory;
-            $data = $pug->cacheDirectory($viewDirectory);
-            $success += $data[0];
-            $errors += $data[1];
         }
 
         return [$directories, $success, $errors];

src/Jade/JadeSymfonyEngine.php

@@ -209,7 +209,7 @@ public function render($name, array $parameters = [])
     {
         foreach (['view', 'this'] as $forbiddenKey) {
             if (array_key_exists($forbiddenKey, $parameters)) {
-                throw new \ArgumentException('The "' . $forbiddenKey . '" key is forbidden.');
+                throw new \ErrorException('The "' . $forbiddenKey . '" key is forbidden.');
             }
         }
         $parameters['view'] = $this;

tests/Pug/PugSymfonyEngineTest.php

@@ -188,14 +188,13 @@ public function testBundleView()
     {
         $pugSymfony = new PugSymfonyEngine(self::$kernel);
 
-        self::assertSame('<p>Hello</p>', trim($pugSymfony->render('TestBundle::bundle.pug')));
+        self::assertSame('<p>Hello</p>', trim($pugSymfony->render('TestBundle::bundle.pug', ['text' => 'Hello'])));
         self::assertSame('<section>World</section>', trim($pugSymfony->render('TestBundle:directory:file.pug')));
     }
 
     public function testFilter()
     {
         $pugSymfony = new PugSymfonyEngine(self::$kernel);
-        $engine = $pugSymfony->getEngine();
 
         self::assertFalse($pugSymfony->hasFilter('upper'));
 
@@ -242,4 +241,22 @@ public function testCustomOptions()
         self::assertSame(5, $pugSymfony->getEngine()->getOption('indentSize'));
         self::assertSame("<div>\n     <p></p>\n</div>", trim($pugSymfony->render('p.pug')));
     }
+
+    /**
+     * @expectedException        \ErrorException
+     * @expectedExceptionMessage The "this" key is forbidden.
+     */
+    public function testForbidThis()
+    {
+        (new PugSymfonyEngine(self::$kernel))->render('p.pug', ['this' => 42]);
+    }
+
+    /**
+     * @expectedException        \ErrorException
+     * @expectedExceptionMessage The "view" key is forbidden.
+     */
+    public function testForbidView()
+    {
+        (new PugSymfonyEngine(self::$kernel))->render('p.pug', ['view' => 42]);
+    }
 }

tests/project/src/TestBundle/Resources/views/bundle.pug

@@ -1 +1 @@
-p Hello
+p=text