Allow Symfony 5 #44

kylekatarnls · 2019-12-01T14:50:15Z

Fix #39
Fix #41

Register the command automatically from the bundle

codecov · 2019-12-01T23:58:36Z

Codecov Report

Merging #44 into master will decrease coverage by 8.53%.
The diff coverage is 69.23%.

@@             Coverage Diff             @@
##             master     #44      +/-   ##
===========================================
- Coverage     98.74%   90.2%   -8.54%     
- Complexity      191     242      +51     
===========================================
  Files             8      12       +4     
  Lines           478     582     +104     
===========================================
+ Hits            472     525      +53     
- Misses            6      57      +51

Impacted Files	Coverage Δ	Complexity Δ
...Jade/JadeSymfonyBundle/Command/PugAwareCommand.php	`0% <0%> (ø)`	`1 <1> (?)`
...JadeSymfonyBundle/Command/AssetsPublishCommand.php	`100% <100%> (ø)`	`14 <0> (+1)`	⬆️
src/Jade/Exceptions/ReservedVariable.php	`100% <100%> (ø)`	`1 <1> (?)`
...rc/Jade/Symfony/Traits/PrivatePropertyAccessor.php	`100% <100%> (ø)`	`1 <1> (?)`
src/Jade/Symfony/Traits/Filters.php	`100% <100%> (ø)`	`3 <0> (ø)`	⬇️
src/Jade/Symfony/MixedLoader.php	`100% <100%> (+66.66%)`	`0 <0> (ø)`	⬇️
src/Jade/Symfony/Traits/Installer.php	`91.7% <15%> (-8.3%)`	`71 <4> (+6)`
src/Jade/Symfony/Traits/Options.php	`83.33% <71.42%> (-16.67%)`	`7 <1> (+1)`
src/Jade/Symfony/Traits/HelpersHandler.php	`90.51% <72.5%> (-9.49%)`	`58 <16> (+14)`
src/Jade/JadeSymfonyEngine.php	`87.77% <75.29%> (-12.23%)`	`77 <37> (+20)`
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e92778a...03420ca. Read the comment docs.

codeclimate · 2019-12-10T17:18:01Z

src/Pug/Twig/EnvironmentBase.php

+            }
+        }
+
+        return parent::render($name, $context);


Reference to undeclared class \Twig\Environment (Did you mean class \Pug\Twig\Environment)

codeclimate · 2019-12-10T17:18:01Z

src/Pug/Twig/EnvironmentBase.php

+
+        $this->classNames[$name] = $cls;
+
+        return parent::loadTemplate($cls, $name, $index);


Reference to undeclared class \Twig\Environment (Did you mean class \Pug\Twig\Environment)

codeclimate · 2019-12-10T17:18:01Z

src/Pug/Twig/EnvironmentBase.php

+            return strtr(file_get_contents($templateFile), $replacements);
+        }
+
+        $html = parent::compileSource($source);


Reference to undeclared class \Twig\Environment (Did you mean class \Pug\Twig\Environment)

codeclimate · 2019-12-10T17:18:02Z

src/Pug/Twig/EnvironmentBase.php

+                '[/* {{debugInfo}} */]' => var_export($debugInfo, true),
+            ];
+
+            if ($this->isDebug()) {


Call to undeclared method \Pug\Twig\EnvironmentBase::isDebug

codeclimate · 2019-12-10T17:18:02Z

src/Pug/Twig/EnvironmentBase.php

+
+            $fileName = $this->isDebug() ? 'PugDebugTemplateTemplate' : 'PugTemplateTemplate';
+            $templateFile = __DIR__ . "/../../../cache-templates/$fileName.php";
+            $name = $source->getName();


Call to method getName from undeclared class \Twig\Source

codeclimate · 2019-12-10T19:04:24Z

src/Pug/Twig/EnvironmentBase.php

+                }
+            }
+
+            $fileName = $this->isDebug() ? 'PugDebugTemplateTemplate' : 'PugTemplateTemplate';


Call to undeclared method \Pug\Twig\EnvironmentBase::isDebug

codeclimate · 2019-12-10T19:04:24Z

src/Pug/Twig/EnvironmentBase.php

+
+            if ($this->isDebug()) {
+                $preRenderLinesCount = $this->pugSymfonyEngine->getPreRenderLinesCount();
+                $formatter = $pug->getCompiler()->getFormatter();


Call to method getCompiler from undeclared class \Pug\Pug

codeclimate · 2019-12-10T19:04:24Z

src/Pug/Twig/EnvironmentBase.php

+            $debugInfo = [$codeFirstLine => $templateLine];
+            $lines = explode("\n", $php);
+
+            if ($this->isDebug()) {


Call to undeclared method \Pug\Twig\EnvironmentBase::isDebug

codeclimate · 2019-12-10T19:04:24Z

src/Pug/Twig/EnvironmentBase.php

+            $pug = $this->pugSymfonyEngine->getEngine();
+            $code = $source->getCode();
+            $php = $pug->compile($code, $path);
+            $codeFirstLine = $this->isDebug() ? 31 : 25;


Call to undeclared method \Pug\Twig\EnvironmentBase::isDebug

codeclimate · 2019-12-10T19:04:24Z

src/Pug/Twig/EnvironmentBase.php

+        if ($this->pugSymfonyEngine->supports($path)) {
+            $pug = $this->pugSymfonyEngine->getEngine();
+            $code = $source->getCode();
+            $php = $pug->compile($code, $path);


Call to method compile from undeclared class \Pug\Pug

codeclimate · 2019-12-10T21:07:03Z

src/Pug/Twig/EnvironmentBase.php

+
+        if ($this->pugSymfonyEngine->supports($path)) {
+            $pug = $this->pugSymfonyEngine->getEngine();
+            $code = $source->getCode();


Call to method getCode from undeclared class \Twig\Source

codeclimate · 2019-12-10T21:07:03Z

src/Pug/Twig/EnvironmentBase.php

+
+    public function compileSourceBase(Source $source)
+    {
+        $path = $source->getPath();


Call to method getPath from undeclared class \Twig\Source

codeclimate · 2019-12-10T21:07:03Z

src/Pug/Twig/EnvironmentBase.php

+            unset($extensions[$key]);
+        }
+
+        $twig->setExtensions($extensions);


Call to undeclared method \Pug\Twig\EnvironmentBase::setExtensions

codeclimate · 2019-12-10T21:07:04Z

src/Pug/Twig/EnvironmentBase.php

+
+        $extensions = $baseTwig->getExtensions();
+
+        foreach (array_keys($twig->getExtensions()) as $key) {


Call to undeclared method \Pug\Twig\EnvironmentBase::getExtensions

codeclimate · 2019-12-10T21:07:04Z

src/Pug/Twig/EnvironmentBase.php

+
+        $twig->setPugSymfonyEngine($pugSymfonyEngine);
+
+        $extensions = $baseTwig->getExtensions();


Call to method getExtensions from undeclared class \Twig\Environment (Did you mean class \Pug\Twig\Environment)

codeclimate · 2019-12-11T22:20:19Z

src/Jade/Symfony/Traits/HelpersHandler.php

+
+            if (version_compare(Environment::VERSION, '3.0.0-dev', '>=') &&
+                !isset($extensions['Symfony\\Bridge\\Twig\\Extension\\AssetExtension'])) {
+                $assetExtension = new AssetExtension(new Packages(new Package(new EmptyVersionStrategy())));


Call to method __construct from undeclared class \Symfony\Component\Asset\Packages

codeclimate · 2019-12-11T22:20:19Z

src/Pug/Twig/EnvironmentBase.php

+            'cache'            => $baseTwig->getCache(true),
+            'auto_reload'      => $baseTwig->isAutoReload(),
+            'optimizations'    => static::getPrivateProperty(
+                $baseTwig->getExtension('Twig\\Extension\\OptimizerExtension'),


Call to method getExtension from undeclared class \Twig\Environment (Did you mean class \Pug\Twig\Environment)

codeclimate · 2019-12-11T22:20:19Z

src/Pug/Twig/EnvironmentBase.php

+                'defaultStrategy'
+            ),
+            'cache'            => $baseTwig->getCache(true),
+            'auto_reload'      => $baseTwig->isAutoReload(),


Call to method isAutoReload from undeclared class \Twig\Environment (Did you mean class \Pug\Twig\Environment)

codeclimate · 2019-12-11T22:20:19Z

src/Pug/Twig/EnvironmentBase.php

+                $baseTwig->getExtension('Twig\\Extension\\EscaperExtension'),
+                'defaultStrategy'
+            ),
+            'cache'            => $baseTwig->getCache(true),


Call to method getCache from undeclared class \Twig\Environment (Did you mean class \Pug\Twig\Environment)

codeclimate · 2019-12-11T22:20:19Z

src/Jade/Symfony/Traits/Filters.php

@@ -19,7 +19,7 @@ trait Filters
     */
    public function filter($name, $filter)
    {
-        $this->jade->filter($name, $filter);
+        $this->pug->filter($name, $filter);


Call to method filter from undeclared class \Pug\Pug

codeclimate · 2019-12-14T14:01:44Z

src/Jade/Symfony/Traits/HelpersHandler.php

+
+            if (version_compare(Environment::VERSION, '3.0.0-dev', '>=') &&
+                !isset($extensions['Symfony\\Bridge\\Twig\\Extension\\AssetExtension'])) {
+                $assetExtension = new AssetExtension(new Packages(new Package(new EmptyVersionStrategy())));


Call to method __construct from undeclared class \Symfony\Bridge\Twig\Extension\AssetExtension

codeclimate · 2019-12-14T14:01:44Z

src/Pug/Twig/EnvironmentBase.php

+            'charset'          => $baseTwig->getCharset(),
+            'strict_variables' => $baseTwig->isStrictVariables(),
+            'autoescape'       => static::getPrivateProperty(
+                $baseTwig->getExtension('Twig\\Extension\\EscaperExtension'),


Call to method getExtension from undeclared class \Twig\Environment (Did you mean class \Pug\Twig\Environment)

codeclimate · 2019-12-14T14:01:44Z

src/Pug/Twig/EnvironmentBase.php

+        $twig = new static($baseTwig->getLoader(), [
+            'debug'            => $baseTwig->isDebug(),
+            'charset'          => $baseTwig->getCharset(),
+            'strict_variables' => $baseTwig->isStrictVariables(),


Call to method isStrictVariables from undeclared class \Twig\Environment (Did you mean class \Pug\Twig\Environment)

codeclimate · 2019-12-14T14:01:44Z

src/Pug/Twig/EnvironmentBase.php

+    {
+        $twig = new static($baseTwig->getLoader(), [
+            'debug'            => $baseTwig->isDebug(),
+            'charset'          => $baseTwig->getCharset(),


Call to method getCharset from undeclared class \Twig\Environment (Did you mean class \Pug\Twig\Environment)

codeclimate · 2019-12-14T14:42:34Z

src/Jade/Symfony/Traits/HelpersHandler.php

@@ -131,7 +212,17 @@ protected function getTwig(ContainerInterface $container)
    {
        $twig = $container->has('twig') ? $container->get('twig') : null;

-        return ($twig instanceof \Twig_Environment || $twig instanceof \Twig\Environment) ? $twig : null;
+        $twig = ($twig instanceof \Twig_Environment || $twig instanceof \Twig\Environment) ? $twig : null;


Checking instanceof against undeclared class \Twig_Environment

codeclimate · 2019-12-14T14:42:34Z

src/Pug/Twig/EnvironmentBase.php

+    public static function fromTwigEnvironment(TwigEnvironment $baseTwig, PugSymfonyEngine $pugSymfonyEngine)
+    {
+        $twig = new static($baseTwig->getLoader(), [
+            'debug'            => $baseTwig->isDebug(),


Call to method isDebug from undeclared class \Twig\Environment (Did you mean class \Pug\Twig\Environment)

codeclimate · 2019-12-14T14:42:34Z

src/Pug/Twig/EnvironmentBase.php

+
+    public static function fromTwigEnvironment(TwigEnvironment $baseTwig, PugSymfonyEngine $pugSymfonyEngine)
+    {
+        $twig = new static($baseTwig->getLoader(), [


Call to method getLoader from undeclared class \Twig\Environment (Did you mean class \Pug\Twig\Environment)

codeclimate · 2019-12-14T14:42:35Z

src/Pug/Twig/EnvironmentBase.php

+
+    public function __construct(LoaderInterface $loader, $options = [])
+    {
+        parent::__construct($loader, $options);


Reference to undeclared class \Twig\Environment (Did you mean class \Pug\Twig\Environment)

codeclimate · 2019-12-14T16:32:11Z

src/Pug/Twig/EnvironmentBase.php

+/**
+ * @codeCoverageIgnore
+ */
+abstract class EnvironmentBase extends TwigEnvironment


Class extends undeclared class \Twig\Environment (Did you mean class \Pug\Twig\Environment)

codeclimate · 2019-12-14T16:32:11Z

src/Pug/Twig/Environment.php

+require_once __DIR__ . '/../../../polyfill/Pug/Twig/EnvironmentTwig' . TwigEnvironment::MAJOR_VERSION . '.php';
+class_alias('Pug\\Twig\\EnvironmentTwig' . TwigEnvironment::MAJOR_VERSION, 'Pug\\Twig\\EnvironmentTwigPolyfill');
+
+class Environment extends EnvironmentTwigPolyfill


Class extends undeclared class \Pug\Twig\EnvironmentTwigPolyfill

codeclimate · 2019-12-14T16:32:11Z

src/Pug/Twig/Environment.php

+
+// @codeCoverageIgnoreStart
+require_once __DIR__ . '/../../../polyfill/Pug/Twig/EnvironmentTwig' . TwigEnvironment::MAJOR_VERSION . '.php';
+class_alias('Pug\\Twig\\EnvironmentTwig' . TwigEnvironment::MAJOR_VERSION, 'Pug\\Twig\\EnvironmentTwigPolyfill');


Reference to constant MAJOR_VERSION from undeclared class \Twig\Environment (Did you mean class \Pug\Twig\Environment)

codeclimate · 2019-12-14T16:32:11Z

src/Pug/Twig/Environment.php

+use Twig\Environment as TwigEnvironment;
+
+// @codeCoverageIgnoreStart
+require_once __DIR__ . '/../../../polyfill/Pug/Twig/EnvironmentTwig' . TwigEnvironment::MAJOR_VERSION . '.php';


Reference to constant MAJOR_VERSION from undeclared class \Twig\Environment (Did you mean class \Pug\Twig\Environment)

codeclimate · 2019-12-15T19:35:18Z

src/Jade/JadeSymfonyEngine.php

+        $node = $nodeEvent->getNode();
+
+        if ($node instanceof ImportNode && $node->getName() === 'include') {
+            $code = new TextNode($node->getToken());


Call to method getToken from undeclared class \Phug\Parser\Node\ImportNode

codeclimate · 2019-12-15T19:35:19Z

src/Pug/Twig/Environment.php

+
+// @codeCoverageIgnoreStart
+require_once __DIR__ . '/../../../polyfill/Pug/Twig/EnvironmentTwig' . TwigEnvironment::MAJOR_VERSION . '.php';
+class_alias('Pug\\Twig\\EnvironmentTwig' . TwigEnvironment::MAJOR_VERSION, 'Pug\\Twig\\EnvironmentTwigPolyfill');


Reference to constant MAJOR_VERSION from undeclared class \Twig\Environment (Did you mean class \Pug\Twig\Environment)

codeclimate · 2019-12-15T19:35:19Z

src/Pug/Twig/Environment.php

+use Twig\Environment as TwigEnvironment;
+
+// @codeCoverageIgnoreStart
+require_once __DIR__ . '/../../../polyfill/Pug/Twig/EnvironmentTwig' . TwigEnvironment::MAJOR_VERSION . '.php';


Reference to constant MAJOR_VERSION from undeclared class \Twig\Environment (Did you mean class \Pug\Twig\Environment)

codeclimate · 2019-12-15T19:35:19Z

src/Jade/Symfony/Traits/Options.php

@@ -88,6 +88,16 @@ public function setOptions(array $options)
     */
    public function setCustomOptions(array $options)
    {
-        return $this->jade->setCustomOptions($options);
+        return $this->pug->setCustomOptions($options);


Call to method setCustomOptions from undeclared class \Pug\Pug

codeclimate · 2019-12-15T19:35:19Z

src/Jade/Symfony/Traits/Options.php

@@ -73,7 +73,7 @@ public function setOption($name, $value)
     */
    public function setOptions(array $options)
    {
-        return $this->jade->setOptions($options);
+        return $this->pug->setOptions($options);


Call to method setOptions from undeclared class \Pug\Pug

codeclimate · 2019-12-15T20:46:48Z

src/Jade/JadeSymfonyEngine.php

+        $node = $nodeEvent->getNode();
+
+        if ($node instanceof ImportNode && $node->getName() === 'include') {
+            $code = new TextNode($node->getToken());


Call to method getToken from undeclared class \Phug\Parser\Node\ImportNode

codeclimate · 2019-12-15T20:46:48Z

src/Pug/Twig/Environment.php

+
+// @codeCoverageIgnoreStart
+require_once __DIR__ . '/../../../polyfill/Pug/Twig/EnvironmentTwig' . TwigEnvironment::MAJOR_VERSION . '.php';
+class_alias('Pug\\Twig\\EnvironmentTwig' . TwigEnvironment::MAJOR_VERSION, 'Pug\\Twig\\EnvironmentTwigPolyfill');


Reference to constant MAJOR_VERSION from undeclared class \Twig\Environment (Did you mean class \Pug\Twig\Environment)

codeclimate · 2019-12-15T20:46:49Z

src/Pug/Twig/Environment.php

+use Twig\Environment as TwigEnvironment;
+
+// @codeCoverageIgnoreStart
+require_once __DIR__ . '/../../../polyfill/Pug/Twig/EnvironmentTwig' . TwigEnvironment::MAJOR_VERSION . '.php';


Reference to constant MAJOR_VERSION from undeclared class \Twig\Environment (Did you mean class \Pug\Twig\Environment)

codeclimate · 2019-12-15T20:46:49Z

src/Jade/Symfony/Traits/Options.php

@@ -88,6 +88,16 @@ public function setOptions(array $options)
     */
    public function setCustomOptions(array $options)
    {
-        return $this->jade->setCustomOptions($options);
+        return $this->pug->setCustomOptions($options);


Call to method setCustomOptions from undeclared class \Pug\Pug

codeclimate · 2019-12-15T20:46:49Z

src/Jade/Symfony/Traits/Options.php

@@ -73,7 +73,7 @@ public function setOption($name, $value)
     */
    public function setOptions(array $options)
    {
-        return $this->jade->setOptions($options);
+        return $this->pug->setOptions($options);


Call to method setOptions from undeclared class \Pug\Pug

codeclimate · 2019-12-15T20:46:52Z

Code Climate has analyzed commit d72382a and detected 145 issues on this pull request.

Here's the issue category breakdown:

Category	Count
Complexity	13
Style	21
Bug Risk	95
Clarity	16

Note: there are 85 critical issues.

The test coverage on the diff in this pull request is 68.7% (80% is the threshold).

This pull request will bring the total coverage in the repository to 89.9% (-10.0% change).

View more on Code Climate.

kylekatarnls added 3 commits November 29, 2019 22:12

[Travis-CI] Add Symfony 5

8e3d987

Implement Symfony 5 compatibility and twig <-> pug cross includes

538be7b

Remove kernel parameter checking to support autowiring

b3d8943

kylekatarnls added the enhancement label Dec 1, 2019

kylekatarnls added this to the 2.8 milestone Dec 1, 2019

kylekatarnls self-assigned this Dec 1, 2019

Fix code style

bcb19a7

kylekatarnls force-pushed the symfony-5 branch from d637c91 to bcb19a7 Compare December 1, 2019 14:53

kylekatarnls added 4 commits December 1, 2019 15:59

Simplify Symfony 5 services auto-config

57b066a

Exclude templates from CodeClimate analysis

4d80339

Simplify auto-installation of Symfony

7201a9b

Make assets:publish command compatible with Symfony 5

78f601f

Register the command automatically from the bundle

kylekatarnls added 3 commits December 2, 2019 01:02

Fix code style

fe8e1f1

[Travis-CI] Debug version detection

73ff0f2

[Travis-CI] Debug version detection

4b9f264

kylekatarnls force-pushed the symfony-5 branch from 73ff0f2 to 4b9f264 Compare December 2, 2019 10:13

kylekatarnls added 4 commits December 2, 2019 11:23

Fix Symfony < 5 unit tests compatibility

5999f25

Fix AssetsHelper compatibility

de040fe

Fix class loading order

1f39ace

Force security.token_storage override in tests

1f1d8c4

pug-php deleted a comment from codeclimate bot Dec 2, 2019

codeclimate bot reviewed Dec 10, 2019

View reviewed changes

Restore backward Pug-php 2 compatibility

0d55e37

kylekatarnls force-pushed the symfony-5 branch from 5e6f28c to 0d55e37 Compare December 10, 2019 20:33

codeclimate bot reviewed Dec 10, 2019

View reviewed changes

Specify cache directory for tests

0b33c03

codeclimate bot reviewed Dec 11, 2019

View reviewed changes

Fallback to app directory if src is missing

38dcb3b

codeclimate bot reviewed Dec 14, 2019

View reviewed changes

Add fallback directory for Symfony < 5

1a8c0de

codeclimate bot reviewed Dec 14, 2019

View reviewed changes

Mock log directory in tests

e330988

codeclimate bot reviewed Dec 14, 2019

View reviewed changes

pug-php deleted a comment from codeclimate bot Dec 14, 2019

kylekatarnls added 3 commits December 14, 2019 19:09

Implement Twig 3 functions support

0fc1e03

Reduce minimum coverage ratio

e93786d

Fix variable name conflict

44a7e15

codeclimate bot reviewed Dec 15, 2019

View reviewed changes

Skip testFallbackAppDir

d72382a

codeclimate bot reviewed Dec 15, 2019

View reviewed changes

kylekatarnls added 3 commits January 10, 2020 08:20

Skip failed tests on Symfony 5

3a4cb08

Separate imports

f9dae1c

Fix Symfony version calculation

03420ca

kylekatarnls force-pushed the symfony-5 branch from 0bd4c9e to 03420ca Compare January 14, 2020 12:48

kylekatarnls mentioned this pull request Jan 14, 2020

Allow Symfony 5 #45

Closed

kylekatarnls merged commit e1d4738 into master Jan 14, 2020

kylekatarnls deleted the symfony-5 branch January 14, 2020 14:09


		$this->classNames[$name] = $cls;

		return parent::loadTemplate($cls, $name, $index);


		$extensions = $baseTwig->getExtensions();

		foreach (array_keys($twig->getExtensions()) as $key) {


		$twig->setPugSymfonyEngine($pugSymfonyEngine);

		$extensions = $baseTwig->getExtensions();

Allow Symfony 5 #44

Allow Symfony 5 #44

Conversation

kylekatarnls commented Dec 1, 2019

codecov bot commented Dec 1, 2019 • edited Loading

Codecov Report

codeclimate bot Dec 10, 2019

Choose a reason for hiding this comment

codeclimate bot Dec 10, 2019

Choose a reason for hiding this comment

codeclimate bot Dec 10, 2019

Choose a reason for hiding this comment

codeclimate bot Dec 10, 2019

Choose a reason for hiding this comment

codeclimate bot Dec 10, 2019

Choose a reason for hiding this comment

codeclimate bot Dec 10, 2019

Choose a reason for hiding this comment

codeclimate bot Dec 10, 2019

Choose a reason for hiding this comment

codeclimate bot Dec 10, 2019

Choose a reason for hiding this comment

codeclimate bot Dec 10, 2019

Choose a reason for hiding this comment

codeclimate bot Dec 10, 2019

Choose a reason for hiding this comment

codeclimate bot Dec 10, 2019

Choose a reason for hiding this comment

codeclimate bot Dec 10, 2019

Choose a reason for hiding this comment

codeclimate bot Dec 10, 2019

Choose a reason for hiding this comment

codeclimate bot Dec 10, 2019

Choose a reason for hiding this comment

codeclimate bot Dec 10, 2019

Choose a reason for hiding this comment

codeclimate bot Dec 11, 2019

Choose a reason for hiding this comment

codeclimate bot Dec 11, 2019

Choose a reason for hiding this comment

codeclimate bot Dec 11, 2019

Choose a reason for hiding this comment

codeclimate bot Dec 11, 2019

Choose a reason for hiding this comment

codeclimate bot Dec 11, 2019

Choose a reason for hiding this comment

codeclimate bot Dec 14, 2019

Choose a reason for hiding this comment

codeclimate bot Dec 14, 2019

Choose a reason for hiding this comment

codeclimate bot Dec 14, 2019

Choose a reason for hiding this comment

codeclimate bot Dec 14, 2019

Choose a reason for hiding this comment

codeclimate bot Dec 14, 2019

Choose a reason for hiding this comment

codeclimate bot Dec 14, 2019

Choose a reason for hiding this comment

codeclimate bot Dec 14, 2019

Choose a reason for hiding this comment

codeclimate bot Dec 14, 2019

Choose a reason for hiding this comment

codeclimate bot Dec 14, 2019

Choose a reason for hiding this comment

codeclimate bot Dec 14, 2019

Choose a reason for hiding this comment

codeclimate bot Dec 14, 2019

Choose a reason for hiding this comment

codeclimate bot Dec 14, 2019

Choose a reason for hiding this comment

codeclimate bot Dec 15, 2019

Choose a reason for hiding this comment

codeclimate bot Dec 15, 2019

Choose a reason for hiding this comment

codeclimate bot Dec 15, 2019

Choose a reason for hiding this comment

codeclimate bot Dec 15, 2019

Choose a reason for hiding this comment

codeclimate bot Dec 15, 2019

Choose a reason for hiding this comment

codecov bot commented Dec 1, 2019 •

edited

Loading