Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Postpone engine initialization #51

Merged
merged 5 commits into from
Feb 6, 2020
Merged

Postpone engine initialization #51

merged 5 commits into from
Feb 6, 2020

Conversation

kylekatarnls
Copy link
Member

@kylekatarnls kylekatarnls commented Feb 6, 2020

Fix #43

@kylekatarnls kylekatarnls added this to the 3.0 milestone Feb 6, 2020
@kylekatarnls kylekatarnls self-assigned this Feb 6, 2020
@codecov
Copy link

codecov bot commented Feb 6, 2020

Codecov Report

Merging #51 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##             master    #51   +/-   ##
=======================================
  Coverage       100%   100%           
- Complexity      195    201    +6     
=======================================
  Files            13     13           
  Lines           516    534   +18     
=======================================
+ Hits            516    534   +18
Impacted Files Coverage Δ Complexity Δ
src/Pug/Symfony/Traits/Options.php 100% <100%> (ø) 10 <0> (+4) ⬆️
src/Pug/PugSymfonyEngine.php 100% <100%> (ø) 41 <0> (+1) ⬆️
src/Pug/Twig/Environment.php 100% <100%> (ø) 31 <11> (-1) ⬇️
src/Pug/Symfony/Traits/HelpersHandler.php 100% <100%> (ø) 58 <12> (+2) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2f2dc9...5c5e64a. Read the comment docs.

@kylekatarnls kylekatarnls merged commit 8aac53f into master Feb 6, 2020
@kylekatarnls kylekatarnls deleted the feature/lazy-engine branch February 6, 2020 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve performances (pug engine lazy load)
1 participant