Upgrade to Symfony 6 #65

kylekatarnls · 2023-01-21T23:46:56Z

Fix #64
Fix #62

codeclimate · 2023-01-21T23:47:19Z

src/Pug/Twig/Environment.php

-     * @var PugSymfonyEngine
-     */
-    protected $pugSymfonyEngine;
+    protected PugSymfonyEngine $pugSymfonyEngine;


syntax error, unexpected 'PugSymfonyEngine' (T_STRING), expecting function (T_FUNCTION) or const (T_CONST)

codeclimate · 2023-01-21T23:47:19Z

src/Pug/Symfony/Traits/PugRenderer.php

+
+trait PugRenderer
+{
+    protected PugSymfonyEngine $pug;


syntax error, unexpected 'PugSymfonyEngine' (T_STRING), expecting function (T_FUNCTION) or const (T_CONST)

codeclimate · 2023-01-21T23:47:19Z

src/Pug/Symfony/Traits/PrivatePropertyAccessor.php


-        return $propertyAccessor->getValue($object);
+            return $propertyAccessor->getValue($object);
+        } catch (ReflectionException) {


syntax error, unexpected ')', expecting '|' or variable (T_VARIABLE)

codeclimate · 2023-01-21T23:47:19Z

src/Pug/Symfony/Traits/Options.php

-        return method_exists($pug, 'hasOption') && !$pug->hasOption($name)
-            ? $default
-            : $pug->getOption($name);
+        return $pug->hasOption($name) ? $pug->getOption($name) : $default;


Call to method hasOption from undeclared class \Pug\Pug

codeclimate · 2023-01-21T23:47:20Z

src/Pug/Symfony/Traits/Options.php

-        return method_exists($pug, 'hasOption') && !$pug->hasOption($name)
-            ? $default
-            : $pug->getOption($name);
+        return $pug->hasOption($name) ? $pug->getOption($name) : $default;


Call to method getOption from undeclared class \Pug\Pug

codeclimate · 2023-01-22T11:29:14Z

src/Pug/Symfony/Traits/Installer.php

+        string $bundleClass,
+        callable $proceedTask,
+        int &$flags,
+    ): void {


syntax error, unexpected ')', expecting variable (T_VARIABLE)

codeclimate · 2023-01-22T11:29:14Z

src/Pug/Symfony/Traits/HelpersHandler.php

-     * @var ContainerInterface
-     */
-    protected $container;
+    protected ContainerInterface $container;


syntax error, unexpected 'ContainerInterface' (T_STRING), expecting function (T_FUNCTION) or const (T_CONST)

codeclimate · 2023-01-22T11:29:15Z

src/Pug/PugSymfonyEngine.php

+    public function __construct(
+        KernelInterface $kernel,
+        TwigEnvironment $twig,
+    ) {


syntax error, unexpected ')', expecting variable (T_VARIABLE)

codeclimate · 2023-01-22T11:29:15Z

src/Pug/PugSymfonyBundle/config/pug.php

+namespace Symfony\Component\DependencyInjection\Loader\Configurator;
+
+return static function (ContainerConfigurator $configurator): void {
+    $services = $configurator->services()


Call to method services from undeclared class \Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator

codeclimate · 2023-01-22T11:29:15Z

src/Pug/PugSymfonyBundle/PugSymfonyBundle.php

-            ]);
-        }
+        $application->addCommands([
+            $this->container->get(AssetsPublishCommand::class),


Reference to constant class from undeclared class \Pug\PugSymfonyBundle\Command\AssetsPublishCommand

codeclimate · 2023-01-22T13:16:03Z

src/Pug/PugSymfonyBundle/PugExtension.php

+ * @author Fabien Potencier <fabien@symfony.com>
+ * @author Jeremy Mikola <jmikola@gmail.com>
+ */
+class PugExtension extends Extension


Class extends undeclared class \Symfony\Component\HttpKernel\DependencyInjection\Extension

codeclimate · 2023-01-22T13:16:03Z

src/Pug/PugSymfonyBundle/PugSymfonyBundle.php

-        }
+        $extension = new PugExtension();
+        $containerBuilder->registerExtension($extension);
+        $containerBuilder->loadFromExtension($extension->getAlias());


Call to undeclared method \Pug\PugSymfonyBundle\PugExtension::getAlias

codeclimate · 2023-01-22T13:16:03Z

src/Pug/PugSymfonyBundle/PugSymfonyBundle.php

-        }
+        $extension = new PugExtension();
+        $containerBuilder->registerExtension($extension);
+        $containerBuilder->loadFromExtension($extension->getAlias());


Call to method loadFromExtension from undeclared class \Symfony\Component\DependencyInjection\ContainerBuilder

codeclimate · 2023-01-22T13:16:04Z

src/Pug/PugSymfonyBundle/PugSymfonyBundle.php

-            $propertyAccessor->setValue($container, $services);
-        }
+        $extension = new PugExtension();
+        $containerBuilder->registerExtension($extension);


Call to method registerExtension from undeclared class \Symfony\Component\DependencyInjection\ContainerBuilder

codeclimate · 2023-01-22T13:16:04Z

src/Pug/PugSymfonyBundle/PugExtension.php

+    public function load(array $configs, ContainerBuilder $container)
+    {
+        $loader = new PhpFileLoader($container, new FileLocator(__DIR__.'/config'));
+        $loader->load('pug.php');


Call to method load from undeclared class \Symfony\Component\DependencyInjection\Loader\PhpFileLoader

codeclimate · 2023-01-22T13:16:40Z

src/Pug/PugSymfonyBundle/Command/AssetsPublishCommand.php

 use Symfony\Component\Console\Command\Command;
 use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Output\OutputInterface;
 use Throwable;

+#[AsCommand(
+    'assets:publish',


syntax error, unexpected ','

codeclimate · 2023-01-22T13:16:40Z

src/Pug/PugSymfonyBundle/PugExtension.php

+{
+    public function load(array $configs, ContainerBuilder $container)
+    {
+        $loader = new PhpFileLoader($container, new FileLocator(__DIR__.'/config'));


Call to method __construct from undeclared class \Symfony\Component\DependencyInjection\Loader\PhpFileLoader

codeclimate · 2023-01-22T13:16:40Z

src/Pug/PugSymfonyBundle/PugExtension.php

+{
+    public function load(array $configs, ContainerBuilder $container)
+    {
+        $loader = new PhpFileLoader($container, new FileLocator(__DIR__.'/config'));


Call to method __construct from undeclared class \Symfony\Component\Config\FileLocator

codeclimate · 2023-01-22T13:16:40Z

src/Pug/Symfony/Traits/HelpersHandler.php

-            }));
+            $options['paths'] = array_unique(array_filter(
+                $options['viewDirectories'],
+                static fn ($path) => $path !== $baseDir,


Line indented incorrectly; expected 12 spaces, found 16

codeclimate · 2023-01-22T13:16:40Z

src/Pug/Symfony/Traits/Installer.php

-    protected static function installSymfonyBundle(IOInterface $io, $dir, $bundle, $bundleClass, $proceedTask, &$flags)
-    {
+    protected static function installSymfonyBundle(
+        IOInterface $io,


Avoid variables with short names like $io. Configured minimum length is 3.

codeclimate · 2023-01-22T13:22:04Z

src/Pug/PugSymfonyEngine.php

@@ -278,10 +284,31 @@ public function getRenderArguments(string $name, array $locals): array
        return [$event->getName(), $this->getParameters($event->getLocals())];
    }

+    public function renderResponse(


Function renderResponse has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.

codeclimate · 2023-01-22T13:22:04Z

src/Pug/Symfony/Traits/HelpersHandler.php

    {
        return is_array($token) ? $token[1] : $token;
    }

-    protected function pushArgument(array &$arguments, string &$argument, bool &$argumentNeedInterpolation)
+    protected function pushArgument(array &$arguments, string &$argument, bool &$argumentNeedInterpolation): void


Avoid excessively long variable names like $argumentNeedInterpolation. Keep variable name length under 20.

codeclimate · 2023-01-22T13:22:04Z

src/Pug/Symfony/Traits/Installer.php

@@ -11,13 +13,19 @@
 */
 trait Installer
 {
-    protected static function askConfirmation(IOInterface $io, $message)
+    protected static function askConfirmation(IOInterface $io, string $message): bool


Avoid variables with short names like $io. Configured minimum length is 3.

codeclimate · 2023-01-22T13:22:04Z

src/Pug/Symfony/Traits/Installer.php

    {
        return !$io->isInteractive() || $io->askConfirmation($message);
    }

-    protected static function installSymfonyBundle(IOInterface $io, $dir, $bundle, $bundleClass, $proceedTask, &$flags)
-    {
+    protected static function installSymfonyBundle(


Remove error control operator '@' on line 30.

codeclimate · 2023-01-22T13:22:05Z

src/Pug/PugSymfonyEngine.php

-                return $container->get($interceptorClass);
-            }, $this->userOptions['interceptors'] ?? []);
+            $interceptors = array_map(
+                static fn (string $interceptorClass) => $container->get($interceptorClass),


Line indented incorrectly; expected 12 spaces, found 16

codeclimate · 2023-01-22T13:37:35Z

src/Pug/PugSymfonyEngine.php

-                return $container->get($interceptorClass);
-            }, $this->userOptions['interceptors'] ?? []);
+            $interceptors = array_map(
+                static fn (string $interceptorClass) => $container->get($interceptorClass),


Space before opening parenthesis of function call prohibited

codeclimate · 2023-01-22T13:37:35Z

src/Pug/PugSymfonyEngine.php

-        return array_unique(array_map(function ($path) {
-            return realpath($path) ?: $path;
-        }, $paths));
+        return array_unique(array_map(static fn ($path) => realpath($path) ?: $path, $paths));


Space before opening parenthesis of function call prohibited

codeclimate · 2023-01-22T13:37:35Z

src/Pug/Symfony/Traits/HelpersHandler.php

-            }));
+            $options['paths'] = array_unique(array_filter(
+                $options['viewDirectories'],
+                static fn ($path) => $path !== $baseDir,


Space before opening parenthesis of function call prohibited

codeclimate · 2023-01-22T13:37:35Z

src/Pug/PugSymfonyBundle/PugExtension.php

+ */
+class PugExtension extends Extension
+{
+    public function load(array $configs, ContainerBuilder $container)


Parameter $container has undeclared type \Symfony\Component\DependencyInjection\ContainerBuilder

codeclimate · 2023-01-22T13:37:35Z

src/Pug/PugSymfonyBundle/PugSymfonyBundle.php

-     * @throws ReflectionException
-     */
-    public function setContainer(ContainerInterface $container = null)
+    public function build(ContainerBuilder $containerBuilder): void


Parameter $containerBuilder has undeclared type \Symfony\Component\DependencyInjection\ContainerBuilder

codeclimate · 2023-01-22T13:50:21Z

src/Pug/PugSymfonyBundle/PugSymfonyBundle.php

-            ]);
-        }
+        $application->addCommands([
+            $this->container->get(AssetsPublishCommand::class),


Reference to undeclared property \Pug\PugSymfonyBundle\PugSymfonyBundle->container

codeclimate · 2023-01-22T13:50:22Z

src/Pug/PugSymfonyBundle/config/pug.php

+
+namespace Symfony\Component\DependencyInjection\Loader\Configurator;
+
+return static function (ContainerConfigurator $configurator): void {


Parameter $configurator has undeclared type \Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator

codeclimate · 2023-01-22T18:28:37Z

src/Pug/PugSymfonyEngine.php

-    public function __construct(KernelInterface $kernel)
-    {
+    public function __construct(
+        protected readonly KernelInterface $kernel,


syntax error, unexpected 'protected' (T_PROTECTED), expecting variable (T_VARIABLE)

codeclimate · 2023-01-22T18:28:37Z

src/Pug/PugSymfonyEngine.php

+        protected readonly KernelInterface $kernel,
+        TwigEnvironment $twig,
+        private readonly ?RequestStack $stack = null,
+        private readonly ?RequestContext $context = null,


Line indented incorrectly; expected 4 spaces, found 8

codeclimate · 2023-01-22T18:28:37Z

src/Pug/PugSymfonyEngine.php

+    public function __construct(
+        protected readonly KernelInterface $kernel,
+        TwigEnvironment $twig,
+        private readonly ?RequestStack $stack = null,


Line indented incorrectly; expected 4 spaces, found 8

codeclimate · 2023-01-22T18:28:37Z

src/Pug/PugSymfonyEngine.php

-    public function __construct(KernelInterface $kernel)
-    {
+    public function __construct(
+        protected readonly KernelInterface $kernel,


Line indented incorrectly; expected 4 spaces, found 8

codeclimate · 2023-03-05T18:09:42Z

Code Climate has analyzed commit 74451b1 and detected 43 issues on this pull request.

Here's the issue category breakdown:

Category	Count
Clarity	5
Style	12
Bug Risk	26

Note: there are 19 critical issues.

View more on Code Climate.

kylekatarnls added 8 commits January 14, 2023 15:40

Upgrade to Symfony 6

326ee58

Use attribute in README

ef07578

Add PugRenderer trait

e6799f8

Add extension in Twig if it's not yet registered

61271af

Fix code style

78df332

Fix class compatibility

65b81db

Update PHP version for GitHub Actions

6df5083

Fix symfony test compatibility

f45ea6d

codeclimate bot reviewed Jan 21, 2023

View reviewed changes

Adapt tests for Symfony 6

65e115b

codeclimate bot reviewed Jan 22, 2023

View reviewed changes

Use getter to create PugSymfonyEngine

d9a6b9c

codeclimate bot reviewed Jan 22, 2023

View reviewed changes

kylekatarnls force-pushed the feature/symfony-6 branch from 7c9ceab to 372f227 Compare January 22, 2023 13:21

codeclimate bot reviewed Jan 22, 2023

View reviewed changes

Fix dynamic properties

0fa499d

kylekatarnls force-pushed the feature/symfony-6 branch from 372f227 to 0fa499d Compare January 22, 2023 13:37

codeclimate bot reviewed Jan 22, 2023

View reviewed changes

Fix asset helper test

74d872e

codeclimate bot reviewed Jan 22, 2023

View reviewed changes

Fix injection for stack and context

b0aefcd

codeclimate bot reviewed Jan 22, 2023

View reviewed changes

Allow only non-empty extension to check support

5395257

kylekatarnls force-pushed the feature/symfony-6 branch from 6a5581c to 5395257 Compare March 5, 2023 17:18

kylekatarnls added 3 commits March 5, 2023 18:21

Load FormExtension for tests

25681ca

Add csrf extension to form factory in tests

7615ab4

Add LogoutUrlExtension in tests

74451b1

kylekatarnls marked this pull request as ready for review March 5, 2023 18:19

kylekatarnls merged commit b8fea34 into master Mar 5, 2023

kylekatarnls deleted the feature/symfony-6 branch March 5, 2023 18:44


		namespace Symfony\Component\DependencyInjection\Loader\Configurator;

		return static function (ContainerConfigurator $configurator): void {

Upgrade to Symfony 6 #65

Upgrade to Symfony 6 #65

Conversation

kylekatarnls commented Jan 21, 2023 • edited Loading

codeclimate bot Jan 21, 2023

Choose a reason for hiding this comment

codeclimate bot Jan 21, 2023

Choose a reason for hiding this comment

codeclimate bot Jan 21, 2023

Choose a reason for hiding this comment

codeclimate bot Jan 21, 2023

Choose a reason for hiding this comment

codeclimate bot Jan 21, 2023

Choose a reason for hiding this comment

codeclimate bot Jan 22, 2023

Choose a reason for hiding this comment

codeclimate bot Jan 22, 2023

Choose a reason for hiding this comment

codeclimate bot Jan 22, 2023

Choose a reason for hiding this comment

codeclimate bot Jan 22, 2023

Choose a reason for hiding this comment

codeclimate bot Jan 22, 2023

Choose a reason for hiding this comment

codeclimate bot Jan 22, 2023

Choose a reason for hiding this comment

codeclimate bot Jan 22, 2023

Choose a reason for hiding this comment

codeclimate bot Jan 22, 2023

Choose a reason for hiding this comment

codeclimate bot Jan 22, 2023

Choose a reason for hiding this comment

codeclimate bot Jan 22, 2023

Choose a reason for hiding this comment

codeclimate bot Jan 22, 2023

Choose a reason for hiding this comment

codeclimate bot Jan 22, 2023

Choose a reason for hiding this comment

codeclimate bot Jan 22, 2023

Choose a reason for hiding this comment

codeclimate bot Jan 22, 2023

Choose a reason for hiding this comment

codeclimate bot Jan 22, 2023

Choose a reason for hiding this comment

codeclimate bot Jan 22, 2023

Choose a reason for hiding this comment

codeclimate bot Jan 22, 2023

Choose a reason for hiding this comment

codeclimate bot Jan 22, 2023

Choose a reason for hiding this comment

codeclimate bot Jan 22, 2023

Choose a reason for hiding this comment

codeclimate bot Jan 22, 2023

Choose a reason for hiding this comment

codeclimate bot Jan 22, 2023

Choose a reason for hiding this comment

codeclimate bot Jan 22, 2023

Choose a reason for hiding this comment

codeclimate bot Jan 22, 2023

Choose a reason for hiding this comment

codeclimate bot Jan 22, 2023

Choose a reason for hiding this comment

codeclimate bot Jan 22, 2023

Choose a reason for hiding this comment

codeclimate bot Jan 22, 2023

Choose a reason for hiding this comment

codeclimate bot Jan 22, 2023

Choose a reason for hiding this comment

codeclimate bot Jan 22, 2023

Choose a reason for hiding this comment

codeclimate bot Jan 22, 2023

Choose a reason for hiding this comment

codeclimate bot Jan 22, 2023

Choose a reason for hiding this comment

codeclimate bot Jan 22, 2023

Choose a reason for hiding this comment

codeclimate bot commented Mar 5, 2023

kylekatarnls commented Jan 21, 2023 •

edited

Loading