This repository has been archived by the owner on Jul 29, 2022. It is now read-only.
fix: platform agnostic react-renderer build process #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice work! I'll merge this in and then see if I can tidy up the new node script. Thanks for your work! |
|
I've reworked the node script in commit 56c1120. Thanks again. |
|
Np at all. That synchronous writing of the file looks so much better. You may also want to axe the babelrc file, since I don't think thats being used now.6 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issue reported at: #12
I understand this may not be the best way to do file creation/appending in node so feel free to refactor into something a little more readable.